fix: validate write mode in write_lance#5191
Open
LuciferYang wants to merge 1 commit into
Open
Conversation
An out-of-contract mode previously fell through to a silent no-op: the
non-stream path left the commit op as None (fragments written, never
committed) and the streaming path silently overwrote. Reject any mode
outside {create, append, overwrite} up front.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_lancenever checked thatmodewas one ofcreate,append, oroverwrite. A typo likemode="upsert"slipped straight through and silently did nothing useful: on the non-stream path the commit op was left asNone, so fragments were written but never committed, and the streaming path quietly fell back to overwrite._validate_write_argsnow rejects any unknown mode up front with aValueErrorlisting the valid options. It runs before the stream/non-stream split, so both paths are covered, and valid modes are unaffected.