feat: add "ThreeLevelNamespaceAdapter" for enforcing 3-level table identifiers#31
Open
shaofengshi wants to merge 1 commit intolance-format:mainfrom
Open
feat: add "ThreeLevelNamespaceAdapter" for enforcing 3-level table identifiers#31shaofengshi wants to merge 1 commit intolance-format:mainfrom
shaofengshi wants to merge 1 commit intolance-format:mainfrom
Conversation
This commit introduces a reusable adapter that enforces exactly 3 levels for table identifiers (catalog.database.table) and at most 2 levels for namespace identifiers (catalog or catalog.database). Key features: - Wraps any LanceNamespace implementation using the Decorator pattern - Validates identifier levels before delegating operations - Provides clear error messages for invalid identifiers - Available in both Java and Python Java implementation: - ThreeLevelNamespaceAdapter class in lance-namespace-impls-core - Comprehensive test suite with 19 test cases (all passing) - Throws InvalidInputException for invalid identifiers Python implementation: - ThreeLevelNamespaceAdapter class exported from lance_namespace_impls - Comprehensive test suite using pytest - Raises ValueError for invalid identifiers - Includes usage examples Benefits: - Separation of concerns: level enforcement separated from core logic - Reusability: any namespace implementation can be wrapped - Consistency: all implementations get the same validation behavior - Maintainability: validation logic centralized in one place This addresses the need for strict 3-level enforcement in catalogs like Unity Catalog and Gravitino without duplicating validation logic across implementations.
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
shaofengshi
changed the title
shaofengshi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a reusable adapter that enforces exactly 3 levels for table identifiers (catalog.database.table) and at most 2 levels for namespace identifiers (catalog or catalog.database).
Key features:
Java implementation:
Python implementation:
Benefits:
This addresses the need for strict 3-level enforcement in catalogs like Unity Catalog and Gravitino without duplicating validation logic across implementations.