fix: implement dropTable and fix deregisterTable semantics for hive2/hive3#12
Merged
jackye1995 merged 4 commits intolance-format:mainfrom Feb 6, 2026
Merged
Conversation
Contributor
Author
|
Hi, @majin1102 @jackye1995 @yanghua . cc this PR when you have free time, Thanks a lot~ |
jackye1995
changed the title
jackye1995
force-pushed
the
zhb-dev-droptable-delete-data
branch
from
d741601 to
7bc8356
Compare
jackye1995
force-pushed
the
zhb-dev-droptable-delete-data
branch
2 times, most recently
from
fa529c3 to
eecb2fa
Compare
…hive3 - Add dropTable() method that deletes both metadata and data (deleteData=true) - Fix deregisterTable() to only remove metadata without deleting data (deleteData=false) - Update both Java and Python implementations for hive2 and hive3 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jackye1995
force-pushed
the
zhb-dev-droptable-delete-data
branch
from
eecb2fa to
be194a6
Compare
jackye1995
added a commit
to lance-format/lance-spark
that referenced
this pull request
Feb 6, 2026
…209) ## Summary - `dropTable()` now calls `namespace.deregisterTable()` which only removes metadata without deleting the underlying data - `purgeTable()` now calls `namespace.dropTable()` which removes metadata and deletes the underlying data ## Changes - Modified `dropTable()` to use `DeregisterTableRequest` and call `namespace.deregisterTable()` - Modified `purgeTable()` to use `DropTableRequest` and call `namespace.dropTable()` - Updated DirectoryNamespace tests to disable `extra_level` config and explicitly create the "default" namespace so that manifest mode is used instead of directory listing mode ## Related PR - lance-format/lance-namespace-impls#12 (implements `dropTable` and `deregisterTable` with proper `deleteData` handling in hive2/hive3 namespaces) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
jackye1995
approved these changes
Feb 6, 2026
Contributor
jackye1995
left a comment
jackye1995
left a comment
There was a problem hiding this comment.
thanks for bringing this up!
Contributor
Author
Very complete and excellent implementation. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dropTable()method that deletes both metadata and data (deleteData=true)deregisterTable()to only remove metadata without deleting data (deleteData=false)Semantic Behavior
dropTable()truederegisterTable()falseChanges
dropTable(), fixedderegisterTable(), refactoreddoDropTable()to acceptdeleteDataparameterdrop_table()method withdeleteData=TrueTest plan
dropTabledeletes data filesderegisterTablepreserves data files🤖 Generated with Claude Code