feat(sql): add direct SQL query support#144
Closed
jja725 wants to merge 2 commits intolance-format:mainfrom
Closed
feat(sql): add direct SQL query support#144jja725 wants to merge 2 commits intolance-format:mainfrom
jja725 wants to merge 2 commits intolance-format:mainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Add SqlQuery and SqlEngine that let users run standard SQL directly against their datasets without requiring a GraphConfig. This is useful for data analytics workflows where users want explicit JOINs and aggregations against node/relationship tables. DataFusion handles SQL parsing and execution.
jja725
force-pushed
the
feat/sql-query-support
branch
from
cc9bea2 to
caa792d
Compare
Collaborator
|
@jja725 Thanks for the contribution! Could you explain the differences between this new interface and the existing |
Contributor
Author
|
Hi @ChunxuTang, my understanding is that |
Collaborator
|
do we still need this pr? looks like the sql interface implemented in another pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SqlQueryandSqlEngine(Rust + Python) for running standard SQL directly against datasets via DataFusion, without requiring aGraphConfigCypherQuery/CypherEnginepatternsTest plan
cargo test --package lance-graph— 14 Rust integration tests + 9 unit tests + doctest passpytest python/tests/test_sql.py— 18 Python tests pass (SqlQuery: 14, SqlEngine: 4)