Skip to content

feat(cypher): add support for return nodes#142

Merged
ChunxuTang merged 5 commits intolance-format:mainfrom
aheev:return-all
Feb 25, 2026
Merged

feat(cypher): add support for return nodes#142
ChunxuTang merged 5 commits intolance-format:mainfrom
aheev:return-all

Conversation

@aheev
Copy link
Contributor

@aheev aheev commented Feb 17, 2026

Achieved returning full node objects by expanding to all properties in logical_plan. Also added unit and system tests

Closes #110

@aheev
Copy link
Contributor Author

aheev commented Feb 17, 2026

@ChunxuTang could you PTAL?

@ChunxuTang
Copy link
Collaborator

@ChunxuTang could you PTAL?

Sure, thanks for the work! I'll take a look in the following few days.

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2026

Codecov Report

❌ Patch coverage is 95.45455% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/lance-graph/src/logical_plan.rs 95.42% 7 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@ChunxuTang ChunxuTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aheev Thanks for the contribution! It generally looks good to me.
Could you fix the CI errors?

Copy link
Collaborator

@ChunxuTang ChunxuTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!
Just left a minor comment.

@aheev aheev requested a review from ChunxuTang February 21, 2026 03:33
Copy link
Collaborator

@ChunxuTang ChunxuTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! LGTM.

Let me re-trigger the workflows to make sure everything is working well.

@aheev
Copy link
Contributor Author

aheev commented Feb 22, 2026

nightly build failed with

   Compiling shellexpand v3.1.1
error[E0308]: mismatched types
   --> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/shellexpand-3.1.1/src/funcs.rs:395:21
    |
394 |                 let var_name = match var_name.as_str() {
    |                                      ----------------- this expression has type `&str`
395 |                     Some(var_name) => var_name,
    |                     ^^^^^^^^^^^^^^ expected `str`, found `Option<_>`
    |
    = note: expected type `str`
               found enum `Option<_>`
...

Some issue with shellexpand installation

@ChunxuTang
Copy link
Collaborator

Hi @aheev, could you merge the master branch and re-push your changes?
We've removed the nightly tests from the CI.

@aheev
Copy link
Contributor Author

aheev commented Feb 25, 2026

Hi @aheev, could you merge the master branch and re-push your changes? We've removed the nightly tests from the CI.

done

@ChunxuTang
Copy link
Collaborator

Thanks! Let me rerun the workflows.

@ChunxuTang ChunxuTang merged commit c62edfb into lance-format:main Feb 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Allow returning all of a query's results by alias, not just property

3 participants