Skip to content

vmwarevSphereHealthCheck.pl: Fix divide by zero crash #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

vmwarevSphereHealthCheck.pl: Fix divide by zero crash #56

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bac04ff
vmwarevSphereHealthCheck.pl: Fix divide by zero crash if filesystem i…
brbecker Jan 27, 2018
06433c4
vmwarevSphereHealthCheck.pl: Make comment clearer.
brbecker Feb 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions perl/vmwarevSphereHealthCheck.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1402,8 +1402,15 @@ sub printVMSummary {
my $vm_disk_path = $disk->diskPath;
my $vm_disk_free = prettyPrintData($disk->freeSpace,'B');
my $vm_disk_cap = prettyPrintData($disk->capacity,'B');
my $vm_perc_free = &restrict_num_decimal_digits((($disk->freeSpace / $disk->capacity) * 100),2);
my $perc_string = getColor($vm_perc_free);
my ($vm_perc_free, $perc_string) = ();
# If the disk is not mounted by the VM, it will show a zero capacity, leading to divide by zero crash when calculating the percent free.
if ($disk->capacity != 0) {
$vm_perc_free = &restrict_num_decimal_digits((($disk->freeSpace / $disk->capacity) * 100),2);
$perc_string = getColor($vm_perc_free);
} else {
$vm_perc_free = "NaN";
$perc_string = "<td bgcolor=\"$red\">NaN %</td>";
}
$disk_string .= "<td><table border=\"1\" width=100%><tr><td>$vm_disk_path</td><td>$vm_disk_free</td><td>$vm_disk_cap</td>$perc_string</tr></table></td>";
}
$vmstorageString .= $disk_string;
Expand Down