fix(l2): fix default vk paths of deployer #4013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes invalid default paths for verification keys (VK) in the L2 deployer configuration. The paths needed updating because the L2 is now run from the cmd/ethrex binary crate instead of its previous location.
- Updated SP1 and RISC0 verification key default paths to correctly navigate from the new binary location
- Fixed path traversal to account for the deeper directory structure of
cmd/ethrex
ManuelBilbao
approved these changes
Aug 11, 2025
There was a problem hiding this comment.
This will only work when used with cargo or similar (not when downloaded from releases). Approved though, since I'm addressing that problem as part of #4014
LeanSerra
approved these changes
Aug 11, 2025
LeanSerra
pushed a commit
that referenced
this pull request
Aug 12, 2025
**Motivation** Paths were invalid because now the L2 is run from the `cmd/ethrex` binary crate. Integration tests were passing because the vk paths are overwritten in the L2 config, to point into the vk file that's on the container's volume root dir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Paths were invalid because now the L2 is run from the
cmd/ethrexbinary crate.Integration tests were passing because the vk paths are overwritten in the L2 config, to point into the vk file that's on the container's volume root dir.