Skip to content

fix(l2): fix l2 integration test job #3258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025
Merged

fix(l2): fix l2 integration test job #3258

merged 2 commits into from
Jun 23, 2025

Conversation

xqft
Copy link
Contributor

@xqft xqft commented Jun 20, 2025

Motivation

This was failing on multiple PRs because the ethrex_dev image was not being built.

The difference between the failing job and the others (which were succeeding) is the runner (larger_runners). Maybe that has something to do with it.

Description

  • adds a step to build ethrex_dev explicitly

Copy link

Lines of code report

Total lines added: 9
Total lines removed: 34
Total lines changed: 43

Detailed view
+----------------------------------------------------+-------+------+
| File                                               | Lines | Diff |
+----------------------------------------------------+-------+------+
| ethrex/cmd/ethrex/bench/import_blocks_benchmark.rs | 32    | -3   |
+----------------------------------------------------+-------+------+
| ethrex/cmd/ethrex/decode.rs                        | 72    | +4   |
+----------------------------------------------------+-------+------+
| ethrex/cmd/ethrex/networks.rs                      | 92    | +1   |
+----------------------------------------------------+-------+------+
| ethrex/cmd/ethrex/utils.rs                         | 148   | +4   |
+----------------------------------------------------+-------+------+
| ethrex/crates/common/types/genesis.rs              | 653   | -31  |
+----------------------------------------------------+-------+------+

@xqft xqft marked this pull request as ready for review June 20, 2025 18:51
@Copilot Copilot AI review requested due to automatic review settings June 20, 2025 18:51
@xqft xqft requested a review from a team as a code owner June 20, 2025 18:51
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses intermittent failures in the L2 integration test workflow by explicitly building the ethrex_dev Docker image before deploying L1 contracts.

  • Adds a dedicated step to build the ethrex_dev image
  • Retains existing deploy step under L2
Comments suppressed due to low confidence (2)

.github/workflows/pr-main_l2.yaml:83

  • [nitpick] The step name is generic—consider renaming it to Build ethrex_dev Docker image for clarity.
      - name: Build L1 docker image

.github/workflows/pr-main_l2.yaml:81

  • [nitpick] This comment describes a workaround—consider adding a linked issue or TODO to track the root cause and remove the workaround once addressed.
      # for some reason the "Start L1 & Deploy contracts" step does not build the ethrex_dev image, used

@Arkenan Arkenan added this pull request to the merge queue Jun 23, 2025
Merged via the queue into main with commit d9d68eb Jun 23, 2025
32 of 34 checks passed
@Arkenan Arkenan deleted the l2/fix_integration_test branch June 23, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants