feat(core): add uninstall filter to cli #3224
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sacha Froment <[email protected]>
sfroment
force-pushed
the
dev/sfroment/add-uninstall-filter
branch
from
c7a1ab5 to
a1bcb32
Compare
sfroment
changed the title
There was a problem hiding this comment.
Pull Request Overview
Introduces an uninstall_filter method to the Ethereum RPC client for completeness and adds corresponding error handling types.
- Adds
uninstall_filterRPC call inEthClient - Defines
UninstallFilterErrorenum and integrates it intoEthClientError - Updates imports to include the new error type
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/networking/rpc/clients/eth/mod.rs | Added uninstall_filter method |
| crates/networking/rpc/clients/eth/errors.rs | Introduced UninstallFilterError enum and updated EthClientError |
Comments suppressed due to low confidence (3)
crates/networking/rpc/clients/eth/mod.rs:1264
- Wrapping the filter ID inside a JSON string may not match the RPC spec if a numeric parameter is expected; verify whether
eth_uninstallFilterrequires a hex string or raw number and adjust accordingly.
params: Some(vec![json!(format!("{filter_id:#x}"))]),
crates/networking/rpc/clients/eth/mod.rs:1259
- [nitpick] Public methods should include a doc comment describing the purpose, parameters, and return value for clarity in the public API.
pub async fn uninstall_filter(&self, filter_id: u64) -> Result<bool, EthClientError> {
crates/networking/rpc/clients/eth/mod.rs:1259
- I don’t see any unit tests covering this new method; please add tests for both the success path and error scenarios.
pub async fn uninstall_filter(&self, filter_id: u64) -> Result<bool, EthClientError> {
Comment on lines
+1260
to
+1261
| let request = RpcRequest { | ||
| id: RpcRequestId::Number(1), |
There was a problem hiding this comment.
Using a hardcoded request ID of 1 may cause collisions when multiple requests are in flight; consider generating a unique ID per call or using a shared atomic counter.
Suggested change
| let request = RpcRequest { | |
| id: RpcRequestId::Number(1), | |
| let unique_id = self.request_id_counter.fetch_add(1, Ordering::SeqCst); | |
| let request = RpcRequest { | |
| id: RpcRequestId::Number(unique_id), |
Copilot uses AI. Check for mistakes.
sfroment
changed the title
sfroment
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make the cli more complete
Description
simply add the call to uninstall filter
Closes #issue_number
Quick Q which scope shall I use ?