Skip to content

feat(l2): implement calldata decode #3204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 23, 2025
Merged

feat(l2): implement calldata decode #3204

merged 6 commits into from
Jun 23, 2025

Conversation

iovoid
Copy link
Contributor

@iovoid iovoid commented Jun 18, 2025

Motivation

We want to be able to decode ABI-packed data.

Description

This PR copies the implementation made for rex, with two slicing operations fixed to avoid panicking.

@iovoid iovoid requested a review from a team as a code owner June 18, 2025 13:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2025 •
edited
Loading

Lines of code report

Total lines added: 217
Total lines removed: 0
Total lines changed: 217

Detailed view 
+--------------------------------------+-------+------+
| File                                 | Lines | Diff |
+--------------------------------------+-------+------+
| ethrex/crates/l2/sdk/src/calldata.rs | 582   | +217 |
+--------------------------------------+-------+------+

tomip01
tomip01 reviewed Jun 18, 2025
View reviewed changes
tomip01
tomip01 approved these changes Jun 19, 2025
View reviewed changes
Copy link
Contributor

@tomip01 tomip01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jrchatruc jrchatruc enabled auto-merge June 19, 2025 20:18
@jrchatruc jrchatruc added this pull request to the merge queue Jun 23, 2025
Merged via the queue into main with commit d89fc93 Jun 23, 2025
13 checks passed
@jrchatruc jrchatruc deleted the feat/calldata-decode branch June 23, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrchatruc jrchatruc jrchatruc approved these changes

@fkrause98 fkrause98 fkrause98 approved these changes

@tomip01 tomip01 tomip01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iovoid @jrchatruc @fkrause98 @tomip01 @avilagaston9