Skip to content

chore(l2): bump sp1 version to 4.1.7 #2610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 5, 2025
Merged

chore(l2): bump sp1 version to 4.1.7 #2610

merged 5 commits into from
May 5, 2025
+21 −19

Conversation

xqft
Copy link
Contributor

@xqft xqft commented Apr 25, 2025

Also update some docs

@xqft xqft requested a review from a team as a code owner April 25, 2025 21:37
@xqft xqft changed the title bump(l2): bump sp1 version to 4.1.7 chore(l2): bump sp1 version to 4.1.7 Apr 25, 2025
JereSalo
JereSalo approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@JereSalo JereSalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. Should we change this line too?

@xqft
Copy link
Contributor Author

xqft commented Apr 25, 2025

yes!! missed that, thank you!

jrchatruc and others added 3 commits April 28, 2025 17:46
@jrchatruc
Merge branch 'main' into l2/bump_sp1
3508588
@xqft
Merge branch 'main' into l2/bump_sp1
019510e
@xqft
fix(l2): bench crate (#2647)
3271f9f 
The pipeline was failing because of:
1. some breaking changes (renamed imports) 
2. a previously existing bug that we didn't catch until #2516 (we were
encoding a leaf node without its leaf flag, so it would be decoded into
an extension leaf and produce a panic)
3. we were executing the prover in L2 mode because we depended on
ethrex-l2 (and in ethrex-prover, which depends on ethrex-l2), and that
crate enables the L2 feature of ethrex-vm by default.
- The solution was to make an `l2` feature for ethrex-l2, which isn't
ideal. A better (but bigger) solution is proposed in #2662
@xqft xqft enabled auto-merge May 5, 2025 14:28
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2025

Lines of code report

Total lines added: 1
Total lines removed: 1
Total lines changed: 2

Detailed view 
+---------------------------------------------+-------+------+
| File                                        | Lines | Diff |
+---------------------------------------------+-------+------+
| ethrex/crates/l2/prover/bench/src/main.rs   | 95    | -1   |
+---------------------------------------------+-------+------+
| ethrex/crates/l2/prover/bench/src/rpc/db.rs | 489   | +1   |
+---------------------------------------------+-------+------+

@xqft xqft added this pull request to the merge queue May 5, 2025
Merged via the queue into main with commit 3f006c1 May 5, 2025
28 of 30 checks passed
@xqft xqft deleted the l2/bump_sp1 branch May 5, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JereSalo JereSalo JereSalo approved these changes

@tomip01 tomip01 tomip01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xqft @JereSalo @tomip01 @jrchatruc