Skip to content

refactor(levm): Call frame refactor #2583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

SDartayet
Copy link
Contributor

Motivation

Improving code readability for some functions.

Description

Removes call_frame as a function parameter for some functions, replacing it with the vm function returning the current call frame where appropriate.

Addresses issue 2542

Copy link

github-actions bot commented Apr 24, 2025

Lines of code report

Total lines added: 0
Total lines removed: 18
Total lines changed: 18

Detailed view
+-----------------------------------------------------+-------+------+
| File                                                | Lines | Diff |
+-----------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/hooks/hook.rs             | 17    | -1   |
+-----------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/opcode_handlers/system.rs | 813   | -8   |
+-----------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/vm.rs                     | 483   | -9   |
+-----------------------------------------------------+-------+------+

Copy link

EF Tests Comparison

Test Name MAIN PR DIFF
Summary: 32931/38385 (85.79%) 897/38385 (2.34%) ⬇️️ -32034
Prague: 5202/5202 (100.00%) 337/5202 (6.48%) ⬇️️ -4865
Cancun: 7608/7608 (100.00%) 375/7608 (4.93%) ⬇️️ -7233
Shanghai: 3214/3214 (100.00%) 43/3214 (1.34%) ⬇️️ -3171
Paris: 2886/2886 (100.00%) 19/2886 (0.66%) ⬇️️ -2867
London: 2904/2915 (99.62%) 23/2915 (0.79%) ⬇️️ -2881
Berlin: 215/2755 (7.80%) 10/2755 (0.36%) ⬇️️ -205
Istanbul: 238/2709 (8.79%) 9/2709 (0.33%) ⬇️️ -229
Petersburg: 2524/2564 (98.44%) 12/2564 (0.47%) ⬇️️ -2512
Constantinople: 2346/2428 (96.62%) 12/2428 (0.49%) ⬇️️ -2334
Byzantium: 2456/2492 (98.56%) 12/2492 (0.48%) ⬇️️ -2444
SpuriousDragon: 588/598 (98.33%) 11/598 (1.84%) ⬇️️ -577
Tangerine: 592/669 (88.49%) 11/669 (1.64%) ⬇️️ -581
Homestead: 1373/1465 (93.72%) 11/1465 (0.75%) ⬇️️ -1362
Frontier: 785/880 (89.20%) 12/880 (1.36%) ⬇️️ -773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant