Skip to content

fix(core): timeout due to node inactivity instead of total load test time #2530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 15, 2025
Merged

fix(core): timeout due to node inactivity instead of total load test time #2530

merged 13 commits into from
May 15, 2025

Conversation

Arkenan
Copy link
Collaborator

@Arkenan Arkenan commented Apr 22, 2025 •
edited
Loading

Changes:

  • Timeout is now smarter. Instead of waiting a fixed amount of time (e.g. 10 minutes) for the whole load test to happen, which is a bit unpredictable, the load test waits at most 1 minute (configurable) of no-updates from the node. This way it's less machine dependent and more based on responsiveness.
  • load-test-ci.json is fixed to be similar to perf-ci.json, but in prague and with the system smart contracts from l1-dev.json deployed.
  • logs are re-added.
  • Readme si fixed.
  • Re-add flamegraph reporter to CI so they are generated on every push.

Closes #2522

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 22, 2025 •
edited
Loading

Lines of code report

Total lines added: 7
Total lines removed: 0
Total lines changed: 7

Detailed view 
+----------------------------------+-------+------+
| File                             | Lines | Diff |
+----------------------------------+-------+------+
| ethrex/cmd/load_test/src/main.rs | 360   | +7   |
+----------------------------------+-------+------+

@Arkenan Arkenan closed this Apr 23, 2025
@Arkenan Arkenan deleted the load_test_smarter_timeout branch April 23, 2025 11:22
@Arkenan Arkenan restored the load_test_smarter_timeout branch April 23, 2025 11:22
@Arkenan Arkenan reopened this Apr 23, 2025
@Arkenan Arkenan changed the title fix(perf): timeout due to node inactivity instead of total load test time fix(core): timeout due to node inactivity instead of total load test time May 15, 2025
@Arkenan Arkenan marked this pull request as ready for review May 15, 2025 16:07
@Arkenan Arkenan requested a review from a team as a code owner May 15, 2025 16:07
mpaulucci
mpaulucci approved these changes May 15, 2025
View reviewed changes
Copy link
Collaborator

@mpaulucci mpaulucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arkenan Arkenan added this pull request to the merge queue May 15, 2025
Merged via the queue into main with commit 621ac95 May 15, 2025
29 checks passed
@Arkenan Arkenan deleted the load_test_smarter_timeout branch May 15, 2025 17:13
fmoletta pushed a commit that referenced this pull request May 15, 2025
@Arkenan @fmoletta
fix(core): timeout due to node inactivity instead of total load test …
9763262 
…time (#2530)

Changes:

- Timeout is now smarter. Instead of waiting a fixed amount of time
(e.g. 10 minutes) for the whole load test to happen, which is a bit
unpredictable, the load test waits at most 1 minute (configurable) of
no-updates from the node. This way it's less machine dependent and more
based on responsiveness.
- load-test-ci.json is fixed to be similar to perf-ci.json, but in
prague and with the system smart contracts from l1-dev.json deployed.
- logs are re-added.
- Readme si fixed.
- Re-add flamegraph reporter to CI so they are generated on every push.

Closes #2522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpaulucci mpaulucci mpaulucci approved these changes

@jrchatruc jrchatruc jrchatruc approved these changes

@fkrause98 fkrause98 fkrause98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flamegraph reporter timeout
4 participants
@Arkenan @mpaulucci @jrchatruc @fkrause98