Skip to content

chore: Remove dead SegmentInfo struct from cairo_runner.rs #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 23, 2025
Merged

chore: Remove dead SegmentInfo struct from cairo_runner.rs #2235

merged 4 commits into from
Oct 23, 2025

Conversation

@MozirDmitriy
Copy link
Contributor

Description

  • Delete an unused duplicate SegmentInfo definition from cairo_runner.rs.
  • The canonical SegmentInfo lives in cairo_pie.rs and is already used across PIE creation, tests, and serialization.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@JulianGCalderon
Copy link
Contributor

Hi @MozirDmitriy, thanks for the contribution! Could you update the changelog?

@MozirDmitriy
Copy link
Contributor Author

Hi @MozirDmitriy, thanks for the contribution! Could you update the changelog?

updated, thank you for review

JulianGCalderon
JulianGCalderon approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@JulianGCalderon JulianGCalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JulianGCalderon JulianGCalderon added this pull request to the merge queue Oct 23, 2025
Merged via the queue into lambdaclass:main with commit a941a53 Oct 23, 2025
89 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igaray igaray igaray approved these changes

@JulianGCalderon JulianGCalderon JulianGCalderon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MozirDmitriy @JulianGCalderon @igaray