Skip to content

fix: ArcTooBig parameter order in assert_le_felt #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: ArcTooBig parameter order in assert_le_felt #2234

wants to merge 4 commits into from
+4 −2

Conversation

VolodymyrBg
Copy link
Contributor

  • Correct the ArcTooBig error payload to match the actual bounds being checked: smallest arc with PRIME/3 and second smallest with PRIME/2.
  • This ensures the error message accurately reflects the validation logic and avoids confusion during debugging.

@JulianGCalderon
Copy link
Contributor

Hi @VolodymyrBg, thanks for the contribution! Could you update the changelog?

@VolodymyrBg
Copy link
Contributor Author

Hi @VolodymyrBg, thanks for the contribution! Could you update the changelog?

Thanks for review, updated changelog

JulianGCalderon
JulianGCalderon approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@JulianGCalderon JulianGCalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igaray igaray igaray approved these changes

@JulianGCalderon JulianGCalderon JulianGCalderon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@VolodymyrBg @JulianGCalderon @igaray