Add_hint_for_splitting_data_for_blake_with_no_encoding #2137

YairVaknin-starkware · 2025-07-15T06:15:46Z

TITLE

Description

Description of the pull request changes and motivation.

Checklist

Linked to Github Issue
Unit tests added
Integration tests added.
This change requires new documentation.
- Documentation has been added/updated.
- CHANGELOG has been updated.

This change is

github-actions · 2025-07-15T06:25:28Z

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     25.644 s ±  0.036 s    [User: 24.885 s, System: 0.756 s]
  Range (min … max):   25.618 s … 25.669 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     25.672 s ±  0.037 s    [User: 24.813 s, System: 0.855 s]
  Range (min … max):   25.646 s … 25.698 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.00 ± 0.00 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.355 s ±  0.016 s    [User: 24.989 s, System: 0.860 s]
  Range (min … max):   14.344 s … 14.366 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     13.948 s ±  0.027 s    [User: 24.961 s, System: 0.881 s]
  Range (min … max):   13.929 s … 13.967 s    2 runs
 
Summary
  hyper_threading_pr threads: 2 ran
    1.03 ± 0.00 times faster than hyper_threading_main threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.802 s ±  0.043 s    [User: 37.344 s, System: 0.987 s]
  Range (min … max):   10.771 s … 10.832 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.434 s ±  0.433 s    [User: 36.984 s, System: 1.073 s]
  Range (min … max):   10.128 s … 10.740 s    2 runs
 
Summary
  hyper_threading_pr threads: 4 ran
    1.04 ± 0.04 times faster than hyper_threading_main threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.482 s ±  0.108 s    [User: 37.756 s, System: 0.996 s]
  Range (min … max):   10.406 s … 10.559 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.346 s ±  0.002 s    [User: 36.856 s, System: 1.107 s]
  Range (min … max):   10.344 s … 10.347 s    2 runs
 
Summary
  hyper_threading_pr threads: 6 ran
    1.01 ± 0.01 times faster than hyper_threading_main threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.286 s ±  0.143 s    [User: 38.309 s, System: 1.045 s]
  Range (min … max):   10.185 s … 10.387 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.214 s ±  0.079 s    [User: 37.632 s, System: 1.134 s]
  Range (min … max):   10.157 s … 10.270 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.01 ± 0.02 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.463 s ±  0.062 s    [User: 38.495 s, System: 1.207 s]
  Range (min … max):   10.419 s … 10.507 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.452 s ±  0.071 s    [User: 37.869 s, System: 1.215 s]
  Range (min … max):   10.402 s … 10.503 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.00 ± 0.01 times faster than hyper_threading_main threads: 16

github-actions · 2025-07-15T06:33:31Z

Benchmark Results for unmodified programs 🚀

Command	Mean [s]	Min [s]	Max [s]	Relative
`base big_factorial`	2.123 ± 0.027	2.098	2.194	1.01 ± 0.01
`head big_factorial`	2.099 ± 0.015	2.082	2.133	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base big_fibonacci`	2.047 ± 0.019	2.026	2.096	1.01 ± 0.01
`head big_fibonacci`	2.036 ± 0.011	2.014	2.050	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base blake2s_integration_benchmark`	7.451 ± 0.035	7.415	7.502	1.00 ± 0.01
`head blake2s_integration_benchmark`	7.430 ± 0.044	7.374	7.505	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base compare_arrays_200000`	2.171 ± 0.016	2.140	2.203	1.01 ± 0.01
`head compare_arrays_200000`	2.159 ± 0.009	2.143	2.170	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base dict_integration_benchmark`	1.424 ± 0.017	1.408	1.468	1.00
`head dict_integration_benchmark`	1.427 ± 0.009	1.406	1.437	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base field_arithmetic_get_square_benchmark`	1.217 ± 0.011	1.201	1.242	1.00
`head field_arithmetic_get_square_benchmark`	1.220 ± 0.010	1.206	1.238	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base integration_builtins`	7.536 ± 0.093	7.435	7.757	1.00 ± 0.01
`head integration_builtins`	7.526 ± 0.063	7.466	7.646	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base keccak_integration_benchmark`	7.676 ± 0.066	7.598	7.835	1.01 ± 0.01
`head keccak_integration_benchmark`	7.635 ± 0.048	7.569	7.712	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base linear_search`	2.149 ± 0.017	2.127	2.190	1.00
`head linear_search`	2.151 ± 0.021	2.134	2.206	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base math_cmp_and_pow_integration_benchmark`	1.497 ± 0.007	1.485	1.504	1.00
`head math_cmp_and_pow_integration_benchmark`	1.506 ± 0.020	1.488	1.556	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base math_integration_benchmark`	1.444 ± 0.008	1.426	1.455	1.00
`head math_integration_benchmark`	1.467 ± 0.019	1.449	1.516	1.02 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base memory_integration_benchmark`	1.208 ± 0.010	1.193	1.226	1.01 ± 0.01
`head memory_integration_benchmark`	1.200 ± 0.006	1.189	1.211	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base operations_with_data_structures_benchmarks`	1.522 ± 0.008	1.505	1.530	1.00
`head operations_with_data_structures_benchmarks`	1.533 ± 0.008	1.519	1.545	1.01 ± 0.01

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`base pedersen`	525.9 ± 4.0	517.9	530.4	1.00
`head pedersen`	526.6 ± 3.2	521.0	531.6	1.00 ± 0.01

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`base poseidon_integration_benchmark`	610.6 ± 7.7	598.3	624.7	1.00
`head poseidon_integration_benchmark`	614.2 ± 5.9	602.6	623.6	1.01 ± 0.02

Command	Mean [s]	Min [s]	Max [s]	Relative
`base secp_integration_benchmark`	1.811 ± 0.012	1.797	1.832	1.00
`head secp_integration_benchmark`	1.825 ± 0.010	1.812	1.846	1.01 ± 0.01

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`base set_integration_benchmark`	672.3 ± 3.5	667.5	677.2	1.00
`head set_integration_benchmark`	674.9 ± 8.6	657.8	690.0	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base uint256_integration_benchmark`	4.205 ± 0.020	4.178	4.236	1.00
`head uint256_integration_benchmark`	4.250 ± 0.099	4.190	4.526	1.01 ± 0.02

codecov · 2025-07-15T06:40:43Z

Codecov Report

Attention: Patch coverage is 97.59036% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.63%. Comparing base (4226352) to head (2a407bc).
Report is 1 commits behind head on starkware-development.

Files with missing lines	Patch %	Lines
..._processor/builtin_hint_processor/blake2s_utils.rs	97.18%	2 Missing ⚠️

Additional details and impacted files

@@                    Coverage Diff                    @@
##           starkware-development    #2137      +/-   ##
=========================================================
- Coverage                  96.63%   96.63%   -0.01%     
=========================================================
  Files                        104      104              
  Lines                      43903    43959      +56     
=========================================================
+ Hits                       42427    42481      +54     
- Misses                      1476     1478       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Yael-Starkware

Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 5 unresolved discussions (waiting on @yuvalsw)

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 283 at r2 (raw file):

    offset += val_len
*/
pub fn blake2s_unpack_felts(

add a comment stating the used endianess for this function and the next one.

Code quote:

pub fn blake2s_unpack_felts(

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 305 at r2 (raw file):

            if val < pow2_63 {
                let (high, low) = val.div_rem(&pow2_32);
                vec![low, high]

why do we need to change this hint to little endian as well?
who are its users?

Code quote:

vec![low, high]

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 335 at r2 (raw file):

    offset += val_len
*/
pub fn blake2s_split_felts_to_u32s(

any reason not to share code between blake2s_split_felts_to_u32s() and blake2s_unpack_felts(), there is some code duplication

Code quote:

pub fn blake2s_split_felts_to_u32s(

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 348 at r2 (raw file):

    let pow2_32 = BigUint::from(1_u32) << 32;

    // Split value into either 2 or 8 32-bit limbs.

Suggestion:

// Split value into 8 32-bit limbs.

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 832 at r2 (raw file):

    #[test]
    #[cfg_attr(target_arch = "wasm32", wasm_bindgen_test)]
    fn blake2s_split_felts_to_u32s() {

code sharing with the previous test would make the code more compact

Code quote:

n blake2s_split_felts_to_u32s() {

YairVaknin-starkware

Reviewable status: 2 of 3 files reviewed, 5 unresolved discussions (waiting on @Yael-Starkware and @yuvalsw)

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 283 at r2 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

add a comment stating the used endianess for this function and the next one.

Done.

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 305 at r2 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

why do we need to change this hint to little endian as well?
who are its users?

It's used by the bl to hash the program when we use blake. No reason to leave it in BE order. It's Better to have this consistent where possible.

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 335 at r2 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

any reason not to share code between blake2s_split_felts_to_u32s() and blake2s_unpack_felts(), there is some code duplication

Done.
It's a bit cleaner separated imo, but if you prefer it, I don't really mind.

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 832 at r2 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

code sharing with the previous test would make the code more compact

Done.
Most of the tests in this repo follow a similar setup. This approach is good for unit tests, imo (better to be explicit), but again, I don't really mind if you prefer it.

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 348 at r2 (raw file):

    let pow2_32 = BigUint::from(1_u32) << 32;

    // Split value into either 2 or 8 32-bit limbs.

Done.

Yael-Starkware

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @YairVaknin-starkware and @yuvalsw)

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 283 at r2 (raw file):

Previously, YairVaknin-starkware wrote…

Done.

I see it inside one of the match arms, but it true for the other arms as well so please move to a more central place.

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 305 at r2 (raw file):

Previously, YairVaknin-starkware wrote…

It's used by the bl to hash the program when we use blake. No reason to leave it in BE order. It's Better to have this consistent where possible.

ok, makes sense,
no external users for this ?

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 813 at r3 (raw file):

            0x123456781234u128 as i128,
            0x1234abcd5678efab1234abcd,
        );

can the function get u128 to avoid the as i128 conversion?

Code quote:

        let (mut vm, ids_data) = prepare_vm_for_splitting_felts_for_blake(
            0x123456781234u128 as i128,
            0x1234abcd5678efab1234abcd,
        );

YairVaknin-starkware

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Yael-Starkware and @yuvalsw)

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 283 at r2 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

I see it inside one of the match arms, but it true for the other arms as well so please move to a more central place.

Done.

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 305 at r2 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

ok, makes sense,
no external users for this ?

I think starkent. I helped them add support for hashing empty arrays yesterday, so I'll continue the discussion and communicate this to them.

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 813 at r3 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

can the function get u128 to avoid the as i128 conversion?

The underling code from the macro converts them to i128, so I prefer the compiler yells at me here, then getting a runtime error. But the cast is anyway unneeded. This was from a previous change that I didn't revert (note that it has a suffix).

Yael-Starkware

Reviewed all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @yuvalsw)

yuvalsw

Reviewed 2 of 3 files at r3, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @Yael-Starkware)

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 272 at r5 (raw file):

pub enum BlakeEncodingMode {
    /// 2 limbs if val < 2⁶³, otherwise 8 limbs after adding 2^255.

is this some weird unicode? better avoid it.

Code quote:

al < 2⁶³,

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 275 at r5 (raw file):

    UseEncoding,
    /// Always 8 limbs.
    NoEncoding,

suggest to reverse the order

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 314 at r5 (raw file):

    let pow2_32 = BigUint::from(1_u32) << 32;
    let pow2_63 = BigUint::from(1_u32) << 63;
    let pow2_255 = BigUint::from(1_u32) << 255;

these are only required for one of the cases.
With helper functions like I suggested below, there might not remain justification for having both the cases in the same function. This will also be more consistent with the other hints, each implemented in a single function.
Need to check how it's gonna look, so not sure yet, but please consider.

Code quote:

    let pow2_63 = BigUint::from(1_u32) << 63;
    let pow2_255 = BigUint::from(1_u32) << 255;

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 329 at r5 (raw file):

                    val = q;
                }
                limbs

this logic repeats twice

Code quote:

                for limb in &mut limbs {
                    let (q, r) = val.div_rem(&pow2_32);
                    *limb = r;
                    val = q;
                }
                limbs

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 340 at r5 (raw file):

                    val += &pow2_255;
                    let mut limbs = vec![BigUint::from(0_u32); 8];
                    for limb in &mut limbs {

why not limbs.iter_mut()?

Code quote:

 in &mut limbs {

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 348 at r5 (raw file):

                }
            }
        })

please split to 2 helper functions. This is too complicated a statement.

Code quote:

        .flat_map(|mut val| match mode {
            BlakeEncodingMode::NoEncoding => {
                // Always 8 limbs.
                let mut limbs = vec![BigUint::from(0_u32); 8];
                for limb in &mut limbs {
                    let (q, r) = val.div_rem(&pow2_32);
                    *limb = r;
                    val = q;
                }
                limbs
            }
            BlakeEncodingMode::UseEncoding => {
                if val < pow2_63 {
                    // 2 limbs: low, high.
                    let (high, low) = val.div_rem(&pow2_32);
                    vec![low, high]
                } else {
                    // 8 limbs after adding 2**255.
                    val += &pow2_255;
                    let mut limbs = vec![BigUint::from(0_u32); 8];
                    for limb in &mut limbs {
                        let (q, r) = val.div_rem(&pow2_32);
                        *limb = r;
                        val = q;
                    }
                    limbs
                }
            }
        })

YairVaknin-starkware

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Yael-Starkware and @yuvalsw)

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 340 at r5 (raw file):

Previously, yuvalsw wrote…

why not limbs.iter_mut()?

does the same and reads better. no need for any method iter_mut exposes now.

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 348 at r5 (raw file):

Previously, yuvalsw wrote…

please split to 2 helper functions. This is too complicated a statement.

Done.

yuvalsw · 2025-07-21T15:03:23Z

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 314 at r5 (raw file):

Previously, yuvalsw wrote…

these are only required for one of the cases.
With helper functions like I suggested below, there might not remain justification for having both the cases in the same function. This will also be more consistent with the other hints, each implemented in a single function.
Need to check how it's gonna look, so not sure yet, but please consider.

You resolved the comment but I don't see the resolution/response.

yuvalsw

Reviewed 2 of 2 files at r6, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Yael-Starkware)

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs line 271 at r6 (raw file):

}

pub enum BlakeEncodingMode {

please also doc the enum

yuvalsw

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Yael-Starkware and @YairVaknin-starkware)

Yael-Starkware

Reviewed 1 of 2 files at r6, 1 of 1 files at r7, 2 of 2 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @YairVaknin-starkware)

yuvalsw

Reviewed 2 of 2 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @YairVaknin-starkware)

YairVaknin-starkware requested a review from Yael-Starkware July 15, 2025 06:15

YairVaknin-starkware force-pushed the yairv/add_hint_splitting_data_for_blake_with_no_encoding branch from f292846 to 31679ec Compare July 15, 2025 07:40

Yael-Starkware requested a review from yuvalsw July 15, 2025 09:06

Yael-Starkware requested changes Jul 15, 2025

View reviewed changes

YairVaknin-starkware force-pushed the yairv/add_hint_splitting_data_for_blake_with_no_encoding branch from 31679ec to ea1ca39 Compare July 15, 2025 11:14

YairVaknin-starkware requested a review from Yael-Starkware July 15, 2025 11:15

YairVaknin-starkware commented Jul 15, 2025

View reviewed changes

Yael-Starkware requested changes Jul 15, 2025

View reviewed changes

YairVaknin-starkware force-pushed the yairv/add_hint_splitting_data_for_blake_with_no_encoding branch from ea1ca39 to f2412d9 Compare July 15, 2025 13:29

YairVaknin-starkware requested a review from Yael-Starkware July 15, 2025 13:29

YairVaknin-starkware commented Jul 15, 2025

View reviewed changes

Yael-Starkware reviewed Jul 15, 2025

View reviewed changes

YairVaknin-starkware changed the title ~~Add_hint_splitting_data_for_blake_with_no_encoding~~ Add_hint_for_splitting_data_for_blake_with_no_encoding Jul 15, 2025

YairVaknin-starkware force-pushed the yairv/add_hint_splitting_data_for_blake_with_no_encoding branch from f2412d9 to 131ab72 Compare July 16, 2025 02:22

yuvalsw requested changes Jul 17, 2025

View reviewed changes

YairVaknin-starkware force-pushed the yairv/add_hint_splitting_data_for_blake_with_no_encoding branch from 131ab72 to 0c26a3f Compare July 20, 2025 09:07

YairVaknin-starkware requested review from Yael-Starkware and yuvalsw July 20, 2025 09:15

YairVaknin-starkware commented Jul 20, 2025

View reviewed changes

yuvalsw approved these changes Jul 21, 2025

View reviewed changes

YairVaknin-starkware force-pushed the yairv/add_hint_splitting_data_for_blake_with_no_encoding branch from 0c26a3f to f8aa071 Compare July 21, 2025 15:24

Add_hint_for_splitting_data_for_blake_with_no_encoding

2a407bc

YairVaknin-starkware force-pushed the yairv/add_hint_splitting_data_for_blake_with_no_encoding branch from f8aa071 to 2a407bc Compare July 21, 2025 22:07

Yael-Starkware approved these changes Jul 22, 2025

View reviewed changes

YairVaknin-starkware added the nochangelog Skip the changelog check label Jul 22, 2025

yuvalsw approved these changes Jul 24, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add_hint_for_splitting_data_for_blake_with_no_encoding #2137

Add_hint_for_splitting_data_for_blake_with_no_encoding #2137

Uh oh!

YairVaknin-starkware commented Jul 15, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 15, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 15, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jul 15, 2025 •

edited

Loading

Uh oh!

Yael-Starkware left a comment

Uh oh!

YairVaknin-starkware left a comment

Uh oh!

Yael-Starkware left a comment

Uh oh!

YairVaknin-starkware left a comment

Uh oh!

Yael-Starkware left a comment

Uh oh!

yuvalsw left a comment

Uh oh!

YairVaknin-starkware left a comment

Uh oh!

yuvalsw commented Jul 21, 2025

Uh oh!

yuvalsw left a comment

Uh oh!

yuvalsw left a comment

Uh oh!

Yael-Starkware left a comment

Uh oh!

yuvalsw left a comment

Uh oh!

Uh oh!

Add_hint_for_splitting_data_for_blake_with_no_encoding #2137

Are you sure you want to change the base?

Add_hint_for_splitting_data_for_blake_with_no_encoding #2137

Uh oh!

Conversation

YairVaknin-starkware commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TITLE

Description

Checklist

Uh oh!

github-actions bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Yael-Starkware left a comment

Choose a reason for hiding this comment

Uh oh!

YairVaknin-starkware left a comment

Choose a reason for hiding this comment

Uh oh!

Yael-Starkware left a comment

Choose a reason for hiding this comment

Uh oh!

YairVaknin-starkware left a comment

Choose a reason for hiding this comment

Uh oh!

Yael-Starkware left a comment

Choose a reason for hiding this comment

Uh oh!

yuvalsw left a comment

Choose a reason for hiding this comment

Uh oh!

YairVaknin-starkware left a comment

Choose a reason for hiding this comment

Uh oh!

yuvalsw commented Jul 21, 2025

Uh oh!

yuvalsw left a comment

Choose a reason for hiding this comment

Uh oh!

yuvalsw left a comment

Choose a reason for hiding this comment

Uh oh!

Yael-Starkware left a comment

Choose a reason for hiding this comment

Uh oh!

yuvalsw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

YairVaknin-starkware commented Jul 15, 2025 •

edited

Loading

github-actions bot commented Jul 15, 2025 •

edited

Loading

github-actions bot commented Jul 15, 2025 •

edited

Loading

codecov bot commented Jul 15, 2025 •

edited

Loading