Skip to content

Fixed incorrect test description #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 52 additions & 4 deletions app/evaluation_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@ def test_returns_is_correct_true_ascii(self):
self.assertFalse(result.get("feedback"))

def test_intersection_is_commutative(self):
"""
Since A n A' is equal to the empty set (by definition of complement)
for any set A, then B' u B should be considered equal to A n A'
"""
response, answer, params = "A n B", "B n A", Params()

result = evaluation_function(response, answer, params)
Expand Down Expand Up @@ -78,6 +74,10 @@ def test_de_morgan(self):
self.assertFalse(result.get("feedback"))

def test_intersection_of_complement(self):
"""
Since A n A' is equal to the empty set (by definition of complement)
for any set A, then B' n B should be considered equal to A n A'
"""
response, answer, params = "B' n B", "A n A'", Params()

result = evaluation_function(response, answer, params)
Expand All @@ -86,6 +86,54 @@ def test_intersection_of_complement(self):
self.assertEqual(result.get("response_latex"), "\\overline{B} \\cap B")
self.assertFalse(result.get("feedback"))

def test_intersection_is_commutative(self):
response, answer, params = "A n B", "B n A", Params()

result = evaluation_function(response, answer, params)

self.assertEqual(result.get("is_correct"), True)
self.assertEqual(result.get("response_latex"), "A \\cap B")

def test_union_of_complement(self):
"""
Since A u A' is equal to the universal set (by definition of complement)
for any set A, then B' u B should be considered equal to A u A'
"""
response, answer, params = "B' u B", "A u A'", Params()

result = evaluation_function(response, answer, params)

self.assertEqual(result.get("is_correct"), True)
self.assertEqual(result.get("response_latex"), "\\overline{B} \\cup B")

def test_de_Morgan(self):
"""
Testing de Morgan's well known laws
"""
response, answer, params = "(A u B)'", "A' n B'", Params()
result = evaluation_function(response, answer, params)

self.assertEqual(result.get("is_correct"), True)
self.assertEqual(result.get("response_latex"), "\\overline{\\left(A \\cup B\\right)}")

response, answer, params = "(A n B)'", "A' u B'", Params()
result = evaluation_function(response, answer, params)

self.assertEqual(result.get("is_correct"), True)
self.assertEqual(result.get("response_latex"), "\\overline{\left(A \\cap B\\right)}")

def test_intersection_of_complement(self):
"""
Since A n A' is equal to the empty set (by definition of complement)
for any set A, then B' n B should be considered equal to A n A'
"""
response, answer, params = "B' n B", "A n A'", Params()

result = evaluation_function(response, answer, params)

self.assertEqual(result.get("is_correct"), True)
self.assertEqual(result.get("response_latex"), "\\overline{B} \\cap B")

def test_returns_is_correct_true_latex(self):
response, answer, params = "A \\cap B", "A n B", Params(is_latex=True)

Expand Down
Loading