What's missing or incorrect
To improve code readability for future contributors and improve compatibility with static analysis tools (such as mypy), I suggest that we add type hints to each function signature.
For example:
def convert_unicode_dashes(expr)
reads easier as:
def convert_unicode_dashes(expr: str) -> List[Tuple[str, str]]
Location
No response
Suggested fix
These changes don't alter anything related to the runtime logic of this repository, so I think the implementation will be straightforward!!
What's missing or incorrect
To improve code readability for future contributors and improve compatibility with static analysis tools (such as
mypy), I suggest that we add type hints to each function signature.For example:
def convert_unicode_dashes(expr)reads easier as:
def convert_unicode_dashes(expr: str) -> List[Tuple[str, str]]Location
No response
Suggested fix
These changes don't alter anything related to the runtime logic of this repository, so I think the implementation will be straightforward!!