Repository navigation
Rename test files to the names the healthcheck imports - #11
Merged
Merged
Conversation
The base layer's healthcheck imports `..evaluation_tests` and `..preview_tests`, so with the old `*_test.py` names it reports import errors in every function created from this template. Rename the files, update the Dockerfile and README, and add a pytest.ini so pytest still collects the `*_tests.py` files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The base layer's healthcheck imports
..evaluation_testsand..preview_tests, but the template shipsevaluation_test.pyandpreview_test.py. Every function created from this template therefore reportstest_import_evaluation_testserrors fromhealthcheck. ArraySymbolicEqual hit the same problem during its 3.12 move (lambda-feedback/ArraySymbolicEqual#20).app/evaluation_test.py→app/evaluation_tests.pyandapp/preview_test.py→app/preview_tests.py(contents unchanged)COPYlines inapp/Dockerfileand the repository structure in the README (the "Getting Started" section already used the_testsnames)pytest.iniwithpython_files = test_*.py *_test.py *_tests.py, because pytest's default patterns don't match*_tests.pyand CI would otherwise collect no testsTested locally on Python 3.12: pytest collects and passes both tests.
🤖 Generated with Claude Code