-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support http2. #494
Support http2. #494
Conversation
Any updates on this? I'm looking to upgrade some existing tests that use |
/cc @rimiti friendly ping, what is blocker to support this? We need this for |
any update on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To update the dependencies to not point to git/forked repositories.
}, | ||
"dependencies": { | ||
"methods": "~1.1.2", | ||
"superagent": "3.8.2" | ||
"superagent": "git+https://github.com/visionmedia/superagent.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"superagent": "git+https://github.com/visionmedia/superagent.git" | |
"superagent": "^8.0.0" |
Maybe point back to superagent@^8.0.0
now that ladjs/superagent#1414 has been merged.
PS: superagent@^8.0.0
is in the master branch package.json at the time of writing.
}, | ||
"devDependencies": { | ||
"body-parser": "^1.18.2", | ||
"cookie-parser": "^1.4.3", | ||
"eslint": "^4.19.1", | ||
"eslint-config-airbnb-base": "^12.1.0", | ||
"eslint-plugin-import": "2.11.0", | ||
"express": "^4.16.3", | ||
"express": "git+https://github.com/sogaani/express.git#initial-support-http2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"express": "git+https://github.com/sogaani/express.git#initial-support-http2", | |
"express": "^4.18.1", |
Similar to ladjs/superagent#1414 (comment), it would be good to depend directly on express@^4.18.1
.
PS: express@^4.18.1
is in the master branch package.json at the time of writing.
This PR looks promising but would need @sogaani to resolve the conflicts or rebase. |
Closed via #793 and released in v6.3.0 |
Hi
This PR adds http2 support to add http2 tests on express.
This PR depend on ladjs/superagent#1399.