Skip to content

GitHub action improvements #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

GitHub action improvements #13

wants to merge 2 commits into from

Conversation

fazzone
Copy link
Contributor

@fazzone fazzone commented Feb 21, 2022

An intended hidden feature of the generated diffs is that clicking the line numbers would link back to the same line in the original github PR diff. Unfortunately,

  • this only worked when we were invoked in the mode where we talk to the github api
  • github changed the html ids that they use for the line numbers

Anyway it should work now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fazzone