How to implement endpoints for specific content-types #1584

Activity

1. mymtw commented on Jun 10, 2020

   

   mymtw

   on Jun 10, 2020

   More actions

   think that you should check both
2. stale commented on Aug 9, 2020

   

   stalebot

   on Aug 9, 2020

   More actions

   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
3. stale

   added

   wontfix

   on Aug 9, 2020
4. eloo commented on Aug 10, 2020

   

   eloo

   on Aug 10, 2020

   Author

   More actions

   for the record:
   i'm now using the following snippet for this use-case:

   import (
   	"encoding/json"
   	"fmt"
   	"net/http"
   	"strings"
   
   	"github.com/labstack/echo/v4"
   )
   
   type MergeJsonBinder struct{}
   
   // Bind implements the `Binder#Bind` function.
   func (b *MergeJsonBinder) Bind(i interface{}, c echo.Context) (err error) {
   	req := c.Request()
   
   	names := c.ParamNames()
   	values := c.ParamValues()
   	params := map[string][]string{}
   	for i, name := range names {
   		params[name] = []string{values[i]}
   	}
   	if req.ContentLength == 0 {
   		return
   	}
   	ctype := req.Header.Get(echo.HeaderContentType)
   	switch {
   	case strings.HasPrefix(ctype, MIMEApplicationMergePatchJSON):
   		if err = json.NewDecoder(req.Body).Decode(i); err != nil {
   			if ute, ok := err.(*json.UnmarshalTypeError); ok {
   				return echo.NewHTTPError(http.StatusBadRequest, fmt.Sprintf("Unmarshal type error: expected=%v, got=%v, field=%v, offset=%v", ute.Type, ute.Value, ute.Field, ute.Offset)).SetInternal(err)
   			} else if se, ok := err.(*json.SyntaxError); ok {
   				return echo.NewHTTPError(http.StatusBadRequest, fmt.Sprintf("Syntax error: offset=%v, error=%v", se.Offset, se.Error())).SetInternal(err)
   			}
   			return echo.NewHTTPError(http.StatusBadRequest, err.Error()).SetInternal(err)
   		}
   	default:
   		return echo.ErrUnsupportedMediaType
   	}
   	return
   }
   

   and something like this in the endpoint handler

   mergeJsonBinder := MergeJsonBinder{}
   		var body map[string]interface{}
   		err := mergeJsonBinder.Bind(&body, c)
   		if err != nil {
   			return err
   		}
   

   maybe this can be adapted and added as an example to the documention?
5. stale

   removed

   wontfix

   on Aug 10, 2020
6. lammel

   added

   docs

   question

   on Sep 2, 2020
7. stale commented on Nov 7, 2020

   

   stalebot

   on Nov 7, 2020

   More actions

   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
8. stale

   added

   wontfix

   on Nov 7, 2020
9. lyda commented on Jan 6, 2024

   

   lyda

   on Jan 6, 2024

   More actions

   I submitted PR #2572 which would fix this issue.
10. vishr commented on Jun 13, 2026

    

    vishr

    on Jun 13, 2026

    Member

    More actions

    This has been answered above and is labeled wontfix. Closing to tidy the tracker — thanks all for the discussion. 🙏
11. vishr

    closed this as completedon Jun 13, 2026