TFTPProviderDriver/HTTPProviderDriver should create symlinks when staging files for local TFTPProvider/HTTPProvider #1662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a local TFTPProviderDriver/HTTPProviderDriver is used, the file sync can be skipped but the symlink creation in the server internal directory shouldn't. Signed-off-by: Robin van der Gracht <[email protected]>
When the internal dir contains a subdir that does not yet exist on the server (i.e. '/srv/tftp/board-23/') the symlink creation will fail. Signed-off-by: Robin van der Gracht <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1662 +/- ##
======================================
Coverage 55.8% 55.8%
======================================
Files 170 170
Lines 13388 13391 +3
======================================
+ Hits 7472 7474 +2
- Misses 5916 5917 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1 task
Bastian-Krause
added
the
needs rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a local TFTPProviderDriver/HTTPProviderDriver is used, the file sync can be skipped but the symlink creation in the server internal directory should still take place.
When the internal dir contains a subdir that does not yet exist on the server (i.e. '/srv/tftp/board-23/') the symlink creation will fail.
Fixes #1661