Video: add screenshot function #1612
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emantor
force-pushed
the
topic/video-screenshot
branch
from
0722e69 to
8894163
Compare
Useful to create screenshots for regression testing. Signed-off-by: Rouven Czerwinski <[email protected]>
Emantor
force-pushed
the
topic/video-screenshot
branch
from
8894163 to
45cfc3a
Compare
|
This should probably be exposed in |
Emantor
force-pushed
the
topic/video-screenshot
branch
2 times, most recently
from
59d9a8c to
d7005cf
Compare
Implement screenshots for HTTP video cameras. For this we factor out the default_port function out of stream() and reuse it for screenshot(). The screenshot function takes the stream, waits for 75 buffers to ensure we have hit an i-frame in the pipeline so we can encode a complete picture and than encodes the picture into a jpeg file. Signed-off-by: Rouven Czerwinski <[email protected]>
Extend the protocol with the screenshot function. Signed-off-by: Rouven Czerwinski <[email protected]>
Emantor
force-pushed
the
topic/video-screenshot
branch
from
d7005cf to
71f9d83
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #1612 +/- ##
========================================
- Coverage 55.8% 55.7% -0.2%
========================================
Files 170 170
Lines 13380 13425 +45
========================================
+ Hits 7469 7478 +9
- Misses 5911 5947 +36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add screenshot support to the
VideoProtocoland implement it for both drivers.Checklist