Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UUUDriver #1587

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

tafilz
Copy link

@tafilz tafilz commented Jan 30, 2025

Description
Changes default binary name from uuu-loader to uuu. The driver will use the usb-path to pass it to -m parameter to specifiy the usb-device to monitor.

With this multiple i.MX devices can be attached to one exporter device.
This has been tested on a Raspberry Pi with 3 attached i.MX8M Nano SoCs in SDP-Mode.
The uuu-tool used the specified usb-device.

Checklist

  • The arguments and description in doc/configuration.rst have been updated
    • not needed
  • PR has been tested
  • Man pages have been regenerated

Copy link
Member

@Emantor Emantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are changing the binary name, is that something that NXP has done since a specific uuu release? If so can you link to the release? It's probably better to add a new driver based on uuu instead of reusing the older driver to not break existing users.

Emantor

This comment was marked as duplicate.

@tafilz
Copy link
Author

tafilz commented Feb 4, 2025

Since we are changing the binary name, is that something that NXP has done since a specific uuu release? If so can you link to the release? It's probably better to add a new driver based on uuu instead of reusing the older driver to not break existing users.

I never found in the documentation mentioned uuu-loader. The documentation also links to mfgtools repo.
I just skimmed through the tags of mfgtools, but didn't find any reference to uuu-loader.

@Emantor
Copy link
Member

Emantor commented Feb 4, 2025

@jremmet what it your opinion on this?

@sknsean
Copy link

sknsean commented Feb 19, 2025

Agree, it's really weird where the uuu-loader name comes from. I have never seen it named anything other that uuu :)

Changes default binary name from `uuu-loader` to `uuu`.
The driver will use the usb-path to pass it to `-m` parameter to
specifiy the usb-device to monitor.

Signed-off-by: Tafil Avdyli <[email protected]>
Signed-off-by: Tafil Avdyli <[email protected]>

cmd = (
[self.tool, '-v', '-m', usb_device]
+ ['-b', self.script] if self.script else []
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ ['-b', self.script] if self.script else []
+ (['-b', self.script] if self.script else [])

I forgot to retest after refactoring the cmd. I'll force push the change

Copy link
Author

@tafilz tafilz Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have successfully retested the bootstrap command on a Raspberry Pi with 3x i.MX8 boards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants