Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new docs [wip] #1308

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

new docs [wip] #1308

wants to merge 16 commits into from

Conversation

elitan
Copy link

@elitan elitan commented Jan 2, 2025

I thought it was time for an upgrade to this wonderful package.

Let me know what you think 🙏

preview: https://kysely-git-new-docs-johan-eliassons-projects.vercel.app/

Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 5:32pm

@elitan elitan changed the title wip new docs Jan 2, 2025
@elitan elitan marked this pull request as ready for review January 2, 2025 19:32
@koskimas
Copy link
Member

koskimas commented Jan 6, 2025

Wow, seems like a huge effort and looks awesome 👍 But why did you do this 😅

There's a lot of automation in the old site that's not transferred here for example. All the examples are automatically generated from the source code. They are now replaced with hardcoded examples.

I don't know about other parts of the docs since everything is now changed.

Since there's 15k changed lines, I won't have time to review all this. But if @igalklebanov has the time and feels like this is a clear improvement, it's all fine by me.

@igalklebanov
Copy link
Member

@koskimas

@elitan and I haven't aligned on the goals/requirements yet. Hopefully it happens this week.

@elitan elitan changed the title new docs new docs [wip] Jan 7, 2025
@nick-w-nick
Copy link
Contributor

@elitan Mass change concerns aside, just wanted to say, sick job on this table of contents scroll indicator, it's super clean.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants