feat: add default to current timestamp #1175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…kysely-org#1085) * add reusable helpers recipe and implement missing expression features * force node 22.4.1 in CI because of an npm bug
* feat: add postgres range types (kysely-org#1086) * feat: support refresh naterialized view * fix tests by adding .materialized() to remove the matview * fix failing test * fix: References typo (kysely-org#1092) * chore: refresh-view-node.ts => refresh-materialized-view-node.ts * chore: export node in index.ts --------- Co-authored-by: Isak <[email protected]> Co-authored-by: Jonathan Wu <[email protected]>
Co-authored-by: Igal Klebanov <[email protected]>
* feat: empty where in plugin * test: add new tests * chore: remove unneccesary typeguards * fix: change to binary operator node * test: update tests to do both in and not in * test: for having * chore: rm test * test: nullable tests * chore: nit * chore: condense suite * chore: db config override * chore: extra console log * chore: empty arr plugin docs * HandleEmptyInListsPlugin initial commit. Co-authored-by: Austin Woon Quan <[email protected]> --------- Co-authored-by: Austin Woon <[email protected]> Co-authored-by: igalklebanov <[email protected]>
igalklebanov
force-pushed
the
feat/default-to-current-timestamp
branch
from
f1c5ac4 to
d2f0a27
Compare
|
Open in Stackblitz • kysely_koa_example commit: |
igalklebanov
force-pushed
the
v0.28
branch
3 times, most recently
from
b9b80bc to
f75bc1e
Compare
igalklebanov
force-pushed
the
v0.28
branch
3 times, most recently
from
e32bb7f to
ca11632
Compare
nick-w-nick
reviewed
Feb 3, 2025
Comment on lines
+14
to
23
| "typesVersions": { | ||
| "<4.6": { | ||
| "*": [ | ||
| "outdated-typescript.d.ts" | ||
| ] | ||
| } | ||
| }, | ||
| "exports": { | ||
| ".": { | ||
| "import": "./dist/esm/index.js", |
There was a problem hiding this comment.
According to the TS documentation, the exports key takes precedence over the typesVersions key.
This change was technically made in TS 4.9, but one of the maintainers indicated here that non-exports keys cannot contribute to the resolution when an exports key is present, so this should still be applicable.
Suggested change
| "typesVersions": { | |
| "<4.6": { | |
| "*": [ | |
| "outdated-typescript.d.ts" | |
| ] | |
| } | |
| }, | |
| "exports": { | |
| ".": { | |
| "import": "./dist/esm/index.js", | |
| "exports": { | |
| ".": { | |
| "types@<4.6": "outdated-typescript.d.ts", | |
| "types": "./dist/esm/index.d.ts", | |
| "import": "./dist/esm/index.js", |
There was a problem hiding this comment.
Hey 👋
You're commenting on the wrong PR.
Anyway, this still works for the version being targeted. If the cutoff eventually happens on a version where typesVersions is no good anymore, we'll change that.
Maybe we could add <4.6 also to exports in case the IDE picks up a newer TS version, but the project uses an older dev dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1162