Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set default values for diagnostic and envoy metrics when user not sets #1997

Merged
merged 7 commits into from
Apr 1, 2025
Merged

feat: set default values for diagnostic and envoy metrics when user not sets #1997

merged 7 commits into from
Apr 1, 2025

Conversation

hisarbalik
Copy link
Contributor

@hisarbalik hisarbalik commented Mar 28, 2025 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Set Istio and Promentues inputs diagnosticMetrics and envoyMetrics disabled when the user omits the fields

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@hisarbalik hisarbalik requested review from a team as code owners March 28, 2025 13:48
@hisarbalik hisarbalik added kind/feature Categorizes issue or PR as related to a new feature. area/metrics MetricPipeline labels Mar 28, 2025
@github-actions github-actions bot added this to the 1.37.0 milestone Mar 28, 2025
NHingerl
NHingerl previously approved these changes Mar 31, 2025
View reviewed changes
@skhalash skhalash self-assigned this Apr 1, 2025
@hisarbalik hisarbalik requested a review from NHingerl April 1, 2025 09:28
@TeodorSAP TeodorSAP modified the milestones: 1.37.0, 1.38.0 Apr 1, 2025
@hisarbalik hisarbalik enabled auto-merge (squash) April 1, 2025 11:55
@hisarbalik hisarbalik merged commit 489965e into kyma-project:main Apr 1, 2025
50 checks passed
@hisarbalik hisarbalik deleted the add-diagnostic-and-envoy-metrics-defaults branch April 1, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skhalash skhalash skhalash approved these changes

@NHingerl NHingerl NHingerl approved these changes

Assignees

@skhalash skhalash

Labels
area/metrics MetricPipeline kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
1.38.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hisarbalik @skhalash @NHingerl @TeodorSAP