Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose telemetry compatibility mode metric #1996

Merged
merged 9 commits into from
Apr 1, 2025
Merged

feat: expose telemetry compatibility mode metric #1996

merged 9 commits into from
Apr 1, 2025

Conversation

hisarbalik
Copy link
Contributor

@hisarbalik hisarbalik commented Mar 28, 2025 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Add new gauge metric telemetry_otelcol_metrics_compatibility_mode, this metric will indicate either compatibility mode enabled (1) or disabled (0)
  • Add new make target to generate docs listing internal telemetry metrics

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@hisarbalik hisarbalik added kind/feature Categorizes issue or PR as related to a new feature. area/logs LogPipeline area/metrics MetricPipeline area/traces TracePipeline area/manager Manager or module changes labels Mar 28, 2025
@hisarbalik hisarbalik requested a review from a team as a code owner March 28, 2025 06:51
@github-actions github-actions bot added this to the 1.37.0 milestone Mar 28, 2025
@hisarbalik hisarbalik requested a review from a team as a code owner March 28, 2025 12:16
@hisarbalik hisarbalik added the area/documentation Documentation changes label Mar 28, 2025
@a-thaler a-thaler enabled auto-merge (squash) April 1, 2025 11:25
@a-thaler a-thaler merged commit 6c53586 into kyma-project:main Apr 1, 2025
50 checks passed
@hisarbalik hisarbalik deleted the expose-telemetry-compatibility-mode-metric branch April 1, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakesh-garimella rakesh-garimella rakesh-garimella approved these changes

@NHingerl NHingerl NHingerl approved these changes

Assignees

@rakesh-garimella rakesh-garimella

Labels
area/documentation Documentation changes area/logs LogPipeline area/manager Manager or module changes area/metrics MetricPipeline area/traces TracePipeline kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
1.37.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hisarbalik @rakesh-garimella @NHingerl @a-thaler