Skip to content

chore: Update watcher certificate manifest #2371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2025
Merged

chore: Update watcher certificate manifest #2371

merged 3 commits into from
Apr 3, 2025

Conversation

amritanshusikdar
Copy link
Contributor

Related issue(s)
Resolves #2347

@amritanshusikdar amritanshusikdar force-pushed the klm-watcher-selfsigned-to-issuer branch 2 times, most recently from 1fb78ad to 0add20f Compare March 28, 2025 10:54
@amritanshusikdar amritanshusikdar marked this pull request as ready for review March 28, 2025 10:55
@amritanshusikdar amritanshusikdar requested a review from a team as a code owner March 28, 2025 10:55
@amritanshusikdar
Copy link
Contributor Author

The second AC requires the klm-watcher-selfsigned to be in the kcp-system namespace. This is causing a so-called "snowball" / "butterfly" effect, i.e., a lot of things require changing since the setup in main.go also has a lot of hardcoded dependencies to istio-system namespace. Such a huge change is outside the scope of this issue, hence the 2nd AC is skipped.

@amritanshusikdar
Copy link
Contributor Author

Another thing to keep in mind is: the management-plane-charts need to be updated as well, as the templating there still relies on ClusterIssuer.

@amritanshusikdar amritanshusikdar mentioned this pull request Mar 28, 2025
Closed
5 tasks
@amritanshusikdar amritanshusikdar force-pushed the klm-watcher-selfsigned-to-issuer branch from 0add20f to 9eb058b Compare March 28, 2025 11:13
@amritanshusikdar amritanshusikdar added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. labels Mar 28, 2025
@amritanshusikdar amritanshusikdar enabled auto-merge (squash) March 28, 2025 21:42
@amritanshusikdar amritanshusikdar merged commit 68366e4 into kyma-project:main Apr 3, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nesmabadr nesmabadr nesmabadr approved these changes

Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Gardener CM] Make klm-watcher-selfsigned ClusterIssuer a Issuer
2 participants
@amritanshusikdar @nesmabadr