rename the cr file in the workflow #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
area/ci
kyma-bot
added
size/M
kyma-bot
added
size/L
marcobebway
reviewed
Feb 2, 2024
Comment on lines
38
to
44
| - name: Rename CR file | ||
| shell: bash | ||
| env: | ||
| CR_FILE: ${{ inputs.CR_FILE }} | ||
| run: | | ||
| # this is where all our default CRs are located. | ||
| ln -s config/samples/default.yaml "./${CR_FILE}" |
There was a problem hiding this comment.
The name says Rename CR file but the step actually creates a symbolic link!
There was a problem hiding this comment.
I thought "Create a symlink" might be harder to understand and the purpose of it might be even harder to understand. On the other hand, creating a symlink is a much cheaper operation compared to cp or mv but has a similar result.
There was a problem hiding this comment.
So, should I rename the step, or should I change the operation to cp or mv?
There was a problem hiding this comment.
IMO, rename it to Create Symlink for CR file.
Also if the symlink already exists, this command will fail, otherwise you can use ln -sf.
marcobebway
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
render-and-upload-manifests-reusable.ymla logic to rename (really, create a symlink) the default CR was added, so that the CR can be uploaded with a different name (not possible via the gh cli).create-changelogscript and use it in thecreate-draft-releaseworkflow instead of using a script located at the repo.get-version-from-branch.shbecause it is no longer needed since the introduction ofget-version-from-release-branch-reusable.yml. It was not used in any place so for, so it's safe to remove it.Related issue(s)