Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint Fix: - funlen - thelper - perfsprint - godox - goconst #65

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Lint Fix: - funlen - thelper - perfsprint - godox - goconst #65

merged 4 commits into from
Feb 1, 2024

Conversation

the1bit
Copy link
Contributor

@the1bit the1bit commented Feb 1, 2024

Description

Changes proposed in this pull request:

  • funlen
  • thelper
  • perfsprint
  • godox
  • goconst

Related issue(s)

Kiss, Tibor added 2 commits February 1, 2024 13:02
@the1bit the1bit requested a review from a team as a code owner February 1, 2024 12:10
@the1bit the1bit requested a review from mfaizanse February 1, 2024 12:10
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 1, 2024
@the1bit the1bit added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/cli Related to all activities around CLI and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Feb 1, 2024
@the1bit the1bit requested a review from marcobebway February 1, 2024 12:11
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 1, 2024
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 1, 2024
@the1bit the1bit requested a review from a team as a code owner February 1, 2024 12:57
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 1, 2024
@kyma-bot kyma-bot merged commit a9cc2c5 into kyma-project:main Feb 1, 2024
5 checks passed
@the1bit the1bit deleted the Lint-Fix--funlen-testify branch February 1, 2024 16:40
@the1bit the1bit mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcobebway marcobebway marcobebway approved these changes

@NHingerl NHingerl NHingerl approved these changes

@mfaizanse mfaizanse Awaiting requested review from mfaizanse mfaizanse is a code owner automatically assigned from kyma-project/eventing

Assignees

@marcobebway marcobebway

@NHingerl NHingerl

Labels
area/cli Related to all activities around CLI cla: yes Indicates the PR's author has signed the CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@the1bit @marcobebway @NHingerl @kyma-bot