Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use reusable linting workflow from kyma-project/eventing-tools #414

Merged
merged 2 commits into from
Jan 18, 2024
Merged

use reusable linting workflow from kyma-project/eventing-tools #414

merged 2 commits into from
Jan 18, 2024

Conversation

friedrichwilken
Copy link
Contributor

@friedrichwilken friedrichwilken commented Jan 18, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

We want to run linting tests as well in the Create release workflow. For that reason, a reusable workflow was created. To avoid code duplication, we should also run this workflow from our dedicated unit-test workflow.

  • use the reuseable linting workflow from kyma-project/eventing-tools
  • fix the execution on release- branches

This was tested by implementing the same workflow here and then, calling it from this repo, resulted in a successful detection of linting issues in this dummy PR:

  Running [/home/runner/golangci-lint-1.55.2-linux-amd64/golangci-lint run --out-format=github-actions --timeout=5m] in [] ...
  Received 7168568 of 7168568 (100.0%), 3.4 MBs/sec
  Error: func `test_sayHello` is unused (unused)
  
  Error: issues found
  Ran golangci-lint in 2371ms

Related issue(s)
issue

@friedrichwilken friedrichwilken requested review from the1bit and a team as code owners January 18, 2024 09:28
@kyma-bot kyma-bot added area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 18, 2024
@friedrichwilken friedrichwilken linked an issue Jan 18, 2024 that may be closed by this pull request
auto-bump images in Create release workflow #361
Closed
3 tasks
@friedrichwilken friedrichwilken force-pushed the use-reusble-linting-workflow-from-kyma-project/eventing-tools branch from 27fc11c to c9109b7 Compare January 18, 2024 09:30
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 18, 2024
@kyma-bot kyma-bot merged commit 5a06dc6 into kyma-project:main Jan 18, 2024
12 checks passed
@friedrichwilken friedrichwilken deleted the use-reusble-linting-workflow-from-kyma-project/eventing-tools branch January 18, 2024 13:25
@friedrichwilken friedrichwilken self-assigned this Jan 22, 2024
@grischperl grischperl modified the milestone: 1.2.0 Feb 4, 2024
@friedrichwilken friedrichwilken removed a link to an issue Feb 8, 2024
auto-bump images in Create release workflow #361
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfaizanse mfaizanse mfaizanse approved these changes

@the1bit the1bit Awaiting requested review from the1bit

Assignees

@mfaizanse mfaizanse

@friedrichwilken friedrichwilken

Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@friedrichwilken @mfaizanse @kyma-bot @grischperl