Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick to release-1.0: Release without version input (#396) #398

Conversation

friedrichwilken
Copy link
Contributor

@friedrichwilken friedrichwilken commented Jan 16, 2024

Description

This PR cherry-picks the changes to the Create workflow, that will remove the manual input of a release version, to the branch release-1.0

For more details see the original PR to main.

Related issue(s)

#360

* Fix release of manifests (kyma-project#340) (kyma-project#341)

* clean up create-release.yml

Clean up the create-release.yml by removing a number of unused and outcommented lines.

* rename release.sh to render_and_upload_manifests.sh

Rename the scripts/release.sh to render_and_upload_manifests.sh to point clearly out, what the script is about.

* call manifest release from create-release.yml

Call the render_and_upload_manifests.sh because it no longer created by a prow job.

* deactivate module-template upload

Deactivate the upload of the module-template. All functionality for the module-template will be removed eventually, in a follow up PR.

* fix reference of env var

* fix reference to release name (kyma-project#342)

* add missing env vars for IMG and MODULE_REGISTERY (kyma-project#343)

* add missing env vars for IMG and MODULE_REGISTERY

* remove arg

* add KUSTOMIZE_VERSION

* fix wrong token (kyma-project#344)

* add missing env vars for IMG and MODULE_REGISTERY

* remove arg

* replace the BOT_GITHUB_TOKEN with the GITHUB_TOKEN

* remove call of make module-build (kyma-project#347)

* remove call of make module-build

We really only need to render the manifests so lets remove module-build.

* revert removal of MODULE_REGISTERY

* fix spelling of env var name (kyma-project#348)

* release-without-version-input

* improve check_sec-scanners-config.sh

rename from check_tag_info.sh to check_sec-scanners-config.sh and add error handling and desciption.

* clean up
@friedrichwilken friedrichwilken requested a review from a team as a code owner January 16, 2024 09:22
@kyma-bot kyma-bot added area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 16, 2024
@friedrichwilken friedrichwilken changed the title Release without version input (#396) Cherry-pick to release-1.0: Release without version input (#396) Jan 16, 2024
@friedrichwilken friedrichwilken linked an issue Jan 16, 2024 that may be closed by this pull request
5 tasks
@friedrichwilken friedrichwilken deleted the cherry-pick-release-without-input branch February 3, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github action: create version number without manual input
2 participants