Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eam dependencies #112

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Upgrade eam dependencies #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca9ca7b
Bump sigs.k8s.io/controller-runtime from 0.16.3 to 0.17.0
dependabot[bot] Jan 16, 2024
735b89a
Upgrade dependencies
muralov Jan 25, 2024
db4c4cf
Upgrade go versions for lint and unit test pipelines
muralov Jan 25, 2024
c7cb54d
Ugrade golangci-lint
muralov Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's implement it as it was done here:
https://github.com/kyma-project/eventing-manager/blob/main/.github/workflows/lint-go.yml
what do you think?

Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ jobs:
steps:
- uses: actions/setup-go@v5
with:
go-version: '1.20'
go-version: '1.21'
- uses: actions/checkout@v4
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
# Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
version: v1.51
version: v1.55
args: --timeout=5m

# Optional: working directory, useful for monorepos
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-test.yml
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's implement it as we we have done here:
https://github.com/kyma-project/eventing-manager/blob/main/.github/workflows/test.yml
what do you think?

Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: Cache Go dependencies
uses: actions/setup-go@v5
with:
go-version: '1.20'
go-version: '1.21'

- name: Execute unit test
run: make test
Loading
Loading