Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Scope finalizer do not add finalizer to Kyma being deleted #986

Merged

Conversation

tmilos77
Copy link
Contributor

  • prevent overwhelming reconciler outcome log entries when Scope did nothing

Description

Changes proposed in this pull request:

  • Scope reconciler do not add finalizer when Kyma has deletionTimestamp to prevent error message Kyma.operator.kyma-project.io "xxxx" is invalid: metadata.finalizers: Forbidden: no new finalizers can be added if the object is being deleted, found new finalizers []string{"cloud-control.kyma-project.io/deletion-hook"}
  • do not log Scope reconciler outcome to avoid majority of produced logs when Scope did nothing due to frequent KLM changes to Kyma

Related issue(s)

+ prevent overwhelming reconciler outcome log entries when Scope did nothing
@tmilos77 tmilos77 requested a review from a team as a code owner January 27, 2025 09:37
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 27, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 27, 2025
@tmilos77 tmilos77 enabled auto-merge (squash) January 27, 2025 09:56
Copy link
Contributor

@dushanpantic dushanpantic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should look into adding additional log levels, so we can actually turn on these logs on demand when necessary (e.g. debug level).

@tmilos77 tmilos77 merged commit 47d71a0 into kyma-project:main Jan 27, 2025
15 checks passed
@tmilos77 tmilos77 deleted the fix-scope-adds-finalier-to-deleted-kyma branch January 27, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants