Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: dont log controller-runtime starting/stopping logs #980

Merged
merged 1 commit into from
Jan 23, 2025
Merged

chore: dont log controller-runtime starting/stopping logs #980

merged 1 commit into from
Jan 23, 2025

Conversation

tmilos77
Copy link
Contributor

Description

Changes proposed in this pull request:

  • wrapped zap log sink with our custom filter messages sink to eliminate certain log entries produced by controller-runtime
  • fixed cyclicQueue to return shuttingDown from Get when shut down
  • fixed SkrLooper to recognize context DeadlineExceeded and Canceled errors and not log them

Related issue(s)

@tmilos77 tmilos77 requested a review from a team as a code owner January 23, 2025 09:19
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 23, 2025
@tmilos77 tmilos77 enabled auto-merge (squash) January 23, 2025 09:44
@tmilos77 tmilos77 merged commit 71afc77 into kyma-project:main Jan 23, 2025
13 checks passed
@tmilos77 tmilos77 deleted the reduce-controller-runtime-logs branch January 23, 2025 09:47
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vandjelk vandjelk vandjelk approved these changes

Assignees

@vandjelk vandjelk

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmilos77 @vandjelk @kyma-bot