Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AwsRedisInstance): make redis upgradable #948

Merged
merged 6 commits into from
Jan 17, 2025
Merged

feat(AwsRedisInstance): make redis upgradable #948

merged 6 commits into from
Jan 17, 2025

Conversation

dushanpantic
Copy link
Contributor

@dushanpantic dushanpantic commented Jan 15, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • Allows AwsRedisInstance to have its EngineVersion upgraded.
    • Certain scenarios where upgrade is cross-family (redis6->redis7) require creation of temporary param group

Related issue(s)
#939

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 15, 2025
@dushanpantic dushanpantic marked this pull request as ready for review January 16, 2025 12:37
@dushanpantic dushanpantic requested a review from a team as a code owner January 16, 2025 12:37
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2025
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 16, 2025
@dushanpantic dushanpantic enabled auto-merge (squash) January 17, 2025 07:57
@dushanpantic dushanpantic merged commit 1448fd9 into kyma-project:main Jan 17, 2025
9 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 17, 2025
@dushanpantic dushanpantic deleted the upgradable-aws-redis branch January 17, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmilos77 tmilos77 tmilos77 approved these changes

Assignees

@tmilos77 tmilos77

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dushanpantic @tmilos77 @kyma-bot