Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nuke does not requeue when no scope #925

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

tmilos77
Copy link
Contributor

Description

Changes proposed in this pull request:

  • use focal.NewWithOptionalScope() so that case when there's no Scope is gracefully handled

Related issue(s)

@tmilos77 tmilos77 requested a review from a team as a code owner December 23, 2024 07:37
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 23, 2024
@tmilos77 tmilos77 enabled auto-merge (squash) December 23, 2024 07:52
@tmilos77 tmilos77 merged commit 5cea66b into kyma-project:main Dec 23, 2024
13 checks passed
@tmilos77 tmilos77 deleted the fix-nuke-no-scope branch December 23, 2024 07:55
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants