Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IpRange): change GCP IpRange naming strategy #371

Merged

Conversation

dushanpantic
Copy link
Contributor

@dushanpantic dushanpantic commented Jul 23, 2024

Description

Changes proposed in this pull request:

  • IpRange that is allocated in GCP is now named by using KCP IpRange resource name (with cm- prefix)
  • Handle backwards compatibility to still be able to load old name
  • When delete range operation is called, name from loaded address is used

Within one GCP project, two different VPC Networks can not have IpRange with same name. This PR should solve the potential conflicts that can occur due to that fact.

Related issue(s)
Fixes #372

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 23, 2024
@dushanpantic dushanpantic marked this pull request as ready for review July 24, 2024 09:38
@dushanpantic dushanpantic requested a review from a team as a code owner July 24, 2024 09:38
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 26, 2024
@kyma-bot kyma-bot merged commit 6544519 into kyma-project:main Jul 26, 2024
7 checks passed
@dushanpantic dushanpantic deleted the fix-gcp-default-iprange-name-collission branch July 26, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GcpNfsVolume provisioning failed
4 participants