Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AwsRedisInstance): add specs for definition of machine details #368

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

dushanpantic
Copy link
Contributor

@dushanpantic dushanpantic commented Jul 22, 2024

Description

Changes proposed in this pull request:

  • spec field to define CacheNodeType (required)
  • spec field to define EngineVersion (optional, defaults to 7.0)
  • spec field to define AutoMinorVersionUpgrade (optional, defaults to false)

Related issue(s)

@dushanpantic dushanpantic requested a review from a team as a code owner July 22, 2024 12:34
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 22, 2024
@dushanpantic dushanpantic changed the title feat(AwsRedisInstance): add specs for definition of engine details feat(AwsRedisInstance): add specs for definition of machine details Jul 22, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 22, 2024
@kyma-bot kyma-bot merged commit 7d01706 into kyma-project:main Jul 22, 2024
7 checks passed
@dushanpantic dushanpantic deleted the skr-aws-redis branch July 22, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants