Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(GcpNfsVolume): make location optional #366

Merged
merged 1 commit into from
Jul 19, 2024
Merged

feat(GcpNfsVolume): make location optional #366

merged 1 commit into from
Jul 19, 2024

Conversation

abalaie
Copy link
Contributor

@abalaie abalaie commented Jul 19, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • making location optional for GcpNfsVolume
  • adding update ability to scope reconciler based on predicate
  • adding shoot provider.workers.zones to scope for GCP

Related issue(s)

Resolves #402

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 19, 2024
@abalaie abalaie marked this pull request as ready for review July 19, 2024 23:18
@abalaie abalaie requested a review from a team as a code owner July 19, 2024 23:18
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2024
ravi-shankar-sap
ravi-shankar-sap approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@ravi-shankar-sap ravi-shankar-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 19, 2024
@kyma-bot kyma-bot merged commit eb3484a into kyma-project:main Jul 19, 2024
7 checks passed
@abalaie abalaie deleted the ab-PHX-180-2 branch September 13, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravi-shankar-sap ravi-shankar-sap ravi-shankar-sap approved these changes

Assignees

@ravi-shankar-sap ravi-shankar-sap

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make location optional in GcpNfsVolume
3 participants
@abalaie @kyma-bot @ravi-shankar-sap