Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(RedisInstance): add AWS KCP reconciler #354

Merged
merged 1 commit into from
Jul 17, 2024
Merged

feat(RedisInstance): add AWS KCP reconciler #354

merged 1 commit into from
Jul 17, 2024

Conversation

dushanpantic
Copy link
Contributor

Description

Changes proposed in this pull request:

  • AWS Redis KCP Reconciler with create and delete scenarios
  • Create scenario has hardcoded redis specs
  • Tests for AWS Redis KCP Reconciler

To be included in follow-up PRs:

  • AWS RedisInstance spec that will be used to configure the aws redis instance

Related issue(s)

@dushanpantic dushanpantic requested a review from a team as a code owner July 17, 2024 09:31
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 17, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 17, 2024
@dushanpantic dushanpantic changed the title wip: feat(RedisInstance): add AWS KCP reconciler feat(RedisInstance): add AWS KCP reconciler Jul 17, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2024
@dushanpantic dushanpantic added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 17, 2024
@kyma-bot kyma-bot merged commit b660db2 into kyma-project:main Jul 17, 2024
7 checks passed
@dushanpantic dushanpantic deleted the kcp-aws-redis branch July 17, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngrkajac ngrkajac ngrkajac approved these changes

Assignees

@ngrkajac ngrkajac

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dushanpantic @ngrkajac @kyma-bot