fix(qt): correct updateWidth button check and banned node filter#2
Open
thepastaclaw wants to merge 2 commits intokwvg:data_txfrom
Open
fix(qt): correct updateWidth button check and banned node filter#2thepastaclaw wants to merge 2 commits intokwvg:data_txfrom
thepastaclaw wants to merge 2 commits intokwvg:data_txfrom
Conversation
Proposals are made in the form of data transactions but look like oddly shaped transactions in the UI, this should help better explain where the proposal fee went.
- updateWidth: use isVisible() instead of isEnabled() for width calculation. Disabled-but-visible buttons should still contribute to the minimum window width since they occupy layout space. - masternodemodel: return 1 instead of 0 for banned nodes with unknown ban time. The 'Hide Banned' filter checks status_value > 0, so returning 0 would let these nodes escape the filter.
Merged
5 tasks
kwvg
force-pushed
the
data_tx
branch
3 times, most recently
from
81c79d6 to
5c22389
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback from CodeRabbit on dashpay#7144:
1.
updateWidth()— useisVisible()instead ofisEnabled()When
setWalletActionsEnabled(false)disables toolbar buttons, they remain visible (greyed out) butupdateWidth()was excluding them from the minimum-width calculation because it checked!isEnabled() || !isVisible(). This meant the window's minimum width no longer matched the visible button count. Changed to check only!isVisible()since width should track layout visibility, not enabled state.2. Banned nodes with unknown ban time — return 1 instead of 0
The 'Hide Banned' filter in
masternodelist.cppchecksstatus_value > 0. Banned nodes with no validban_heightwere returning 0 inEditRole, bypassing the filter. Changed to return 1 so these nodes are correctly hidden.🤖 This was generated by an automated review bot.
Don't want automated PRs or comments on your code? You can opt out by replying here or messaging @PastaPastaPasta on Slack — we'll make sure the bot skips your PRs/repos going forward.