Add 2D/3D convolution support with tests and benchmarks#4
Open
Conversation
Owner
kwsp
commented
Mar 12, 2026
- Add ND convolution engine (FFTConvEngineND) with cached FFTW plans for 2D and 3D FFT-based convolution (full and same modes)
- Fix member init order in FFTConvBufferND to match declaration order
- Add C++ unit tests for 2D (test_fftconv2d.cpp) and 3D (test_fftconv3d.cpp)
- Add C++ benchmarks for 2D and 3D convolution in bench_fftconv.cpp
- Add pybind11 bindings for convolve2d/convolve3d (double and float)
- Export convolve2d, convolve2d_, convolve3d, convolve3d_ in Python package
- Add Python tests validating against scipy.signal.fftconvolve
- Add Python benchmark script (bench_nd.py) comparing against numpy/scipy
- Update test/CMakeLists.txt to include 2D/3D test sources
- Add ND convolution engine (FFTConvEngineND) with cached FFTW plans for 2D and 3D FFT-based convolution (full and same modes) - Fix member init order in FFTConvBufferND to match declaration order - Add C++ unit tests for 2D (test_fftconv2d.cpp) and 3D (test_fftconv3d.cpp) - Add C++ benchmarks for 2D and 3D convolution in bench_fftconv.cpp - Add pybind11 bindings for convolve2d/convolve3d (double and float) - Export convolve2d, convolve2d_, convolve3d, convolve3d_ in Python package - Add Python tests validating against scipy.signal.fftconvolve - Add Python benchmark script (bench_nd.py) comparing against numpy/scipy - Update test/CMakeLists.txt to include 2D/3D test sources Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.