update checkpoint config and fix log crashes #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchappelow
previously approved these changes
Feb 26, 2025
Comment on lines
+37
to
+54
| case *blockProposal: | ||
| return cm.Msg.(*blockProposal).String() | ||
| case *blockAnnounce: | ||
| return cm.Msg.(*blockAnnounce).String() | ||
| case *vote: | ||
| return cm.Msg.(*vote).String() |
There was a problem hiding this comment.
Do any of these Stringers get long? Switching the log from type to full string could get long?
It looks like in most cases we show the details elsewhere anyway? For example, without this log change:
2025-02-26 17:55:59.184 [INF] NODE: Accept proposal? {height=2823 blockID=80e82f7d1c7221352833b758b2623ebbe176a16f10894bd1aea8d06b151f14d8 prevHash=7222dbed39d06608a5c0d9847c04116d8995711732b3f27882f948eec96de2db from_peer=0226b3ff29216dac187cea393f8af685ad419ac9644e55dce83d145c8b1af213bd#secp256k1}
2025-02-26 17:55:59.185 [INF] NODE: processing block proposal {height=2823 hash=80e82f7d1c7221352833b758b2623ebbe176a16f10894bd1aea8d06b151f14d8 from=0226b3ff29216dac187cea393f8af685ad419ac9644e55dce83d145c8b1af213bd#secp256k1}
2025-02-26 17:55:59.185 [INF] CONS: Consensus message received {type=block_proposal sender=0226b3ff29216dac187cea393f8af685ad419ac9644e55dce83d145c8b1af213bd}
Related: #1349
There was a problem hiding this comment.
Will handle the sync logs issue in a different PR, need to think through that a bit.
charithabandi
force-pushed
the
checkpoint
branch
from
c5b67f8 to
9b018da
Compare
|
conflicts, but will approve again |
charithabandi
force-pushed
the
checkpoint
branch
from
9b018da to
aabcba6
Compare
jchappelow
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.