[WIP] common,bp,txapp: call notices and row results in log, and use log from tx routes #1368
Conversation
Curious, what might these be? |
I need to think it though, but it seems like if this is the case then it adds some considerations to the action author. For instance, perhaps an action is best suited to serve other actions, so it returns largish tables, and the other actions return more reasonably (small) results. So directly calling the action with a large table return ends up with a transaction with a large log. Maybe modifiers can avoid that, or perhaps log length limits? |
| // TODO: once we are able to store execution logs in the block store, we should propagate the discarded | ||
| // return value here. | ||
| _, err := app.Engine.Call(makeEngineCtx(ctx), app.DB, d.namespace, d.action, d.args[i], func(r *common.Row) error { | ||
| // we throw away all results for execute actions |
There was a problem hiding this comment.
@charithabandi Since you were asking, this is the very old TODO I was attempting to address. There are two things we can put in the tx log: (1) the db tx "logs" which are emitted notices, and (2) returned data from the action.
My hesitation with this PR is twofold: (1) if the schema author is not cautious about the size of data returned and possibly modifiers (like owner or private), this could result in enormous txResults that bloat the chain and network traffic in commit info, and (2) what is the format and structure for the tx log (I'm just experimenting with a human readable format here).
|
Closing in favor of #1439 |
JUST TESTING.
I'm experimenting with putting results from action execution in the transaction log:
I think there are gotchas when a table is returned, but I like the possibility to have action returns go somewhere.