Ext 4.2.0 compatibility #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The set of filtered records (valueStore) were REPLACED by selected records in the page currently loaded in the combo box store (store). Consequently, the user's previous selection was lost when the user made a new selection from a disjoint page loaded into the combo box store.
This solution was contributed by user "WebProgrammer" on Sencha Forums: http://www.sencha.com/forum/showthread.php?134751&p=952915
|
Awesome! Now if only @kveeiv would merge this pull request. 😅 |
|
These patches work for me as well! However, I did not verify backwards compatibility, but people should be moving towards 4.2 from 4.1 anyhow... lots of significant fixes in extjs overall. |
|
This looks great, but having one big problem: Will not allow for typing text within the boxselect. If triggerOnClick = true then I can select any of the items that are shown...but if = false then I can't do anything. Almost like the box is disabled altogether, however it worked fine before switching to this pull request version? |
|
This is great, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches make the boxselect plugin work under Ext 4.2.0. 🍰