Skip to content

Commit

Permalink
Merge pull request #87 from kumiori/andres-joss-review
Browse files Browse the repository at this point in the history
Andres joss review
  • Loading branch information
kumiori authored Oct 8, 2024
2 parents 5baee39 + ba5e9e0 commit 94d05f8
Show file tree
Hide file tree
Showing 13 changed files with 2,070 additions and 16 deletions.
2 changes: 1 addition & 1 deletion playground/nb/1d-fundamental-bar.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"import sympy as sp\n",
"import numpy as np\n",
"import matplotlib.pyplot as plt\n",
"import postprocess as pp\n",
"import irrevolutions.utils.postprocess as pp\n",
"# import plots\n",
"import os"
]
Expand Down
2,042 changes: 2,042 additions & 0 deletions playground/nb/JOSS_paper_figures_rayleigh_benchmark.ipynb

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion playground/nb/class_stability.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
],
"source": [
"# Testing Pacman\n",
"import postprocess as pp\n",
"import irrevolutions.utils.postprocess as pp\n",
"import plots as plots\n",
"import sympy as sp\n",
"import numpy as np\n",
Expand Down
2 changes: 1 addition & 1 deletion playground/nb/cone-stability.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
],
"source": [
"# Testing Pacman\n",
"import postprocess as pp \n",
"import irrevolutions.utils.postprocess as pp \n",
"import plots as plots\n"
]
},
Expand Down
2 changes: 1 addition & 1 deletion playground/nb/convergence.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"import sympy as sp\n",
"import numpy as np\n",
"import matplotlib.pyplot as plt\n",
"import postprocess as pp\n",
"import irrevolutions.utils.postprocess as pp\n",
"import plots"
]
},
Expand Down
2 changes: 1 addition & 1 deletion playground/nb/discrete-bar.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"metadata": {},
"outputs": [],
"source": [
"import postprocess as pp\n",
"import irrevolutions.utils.postprocess as pp\n",
"import plots as plots\n"
]
},
Expand Down
2 changes: 1 addition & 1 deletion playground/nb/multifissa.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
],
"source": [
"# Testing Pacman\n",
"import postprocess as pp\n",
"import irrevolutions.utils.postprocess as pp\n",
"# import plots as plots"
]
},
Expand Down
2 changes: 1 addition & 1 deletion playground/nb/pacman-stability.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
],
"source": [
"# Testing Pacman\n",
"import postprocess as pp\n",
"import irrevolutions.utils.postprocess as pp\n",
"import plots as plots\n",
"import sympy as sp\n",
"import numpy as np\n",
Expand Down
2 changes: 1 addition & 1 deletion playground/nb/pacman.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
],
"source": [
"# Testing Pacman\n",
"# import postprocess as pp\n",
"# import irrevolutions.utils.postprocess as pp\n",
"\n",
"import sympy as sp\n",
"import numpy as np\n",
Expand Down
2 changes: 1 addition & 1 deletion playground/nb/parametric.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"outputs": [],
"source": [
"# Testing Pacman\n",
"import postprocess as pp\n",
"import irrevolutions.utils.postprocess as pp\n",
"import plots as plots\n",
"import json\n",
"import pandas as pd"
Expand Down
4 changes: 2 additions & 2 deletions playground/nb/rayleigh_benchmark.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"import sympy as sp\n",
"import numpy as np\n",
"import matplotlib.pyplot as plt\n",
"import postprocess as pp\n",
"import irrevolutions.utils.postprocess as pp\n",
"# import plots\n",
"import os\n",
"\n",
Expand Down Expand Up @@ -4653,7 +4653,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.11.6"
"version": "3.12.2"
},
"orig_nbformat": 4
},
Expand Down
22 changes: 17 additions & 5 deletions playground/rayleigh/JOSS_paper_figures_rayleigh_benchmark.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,26 @@
"cells": [
{
"cell_type": "code",
"execution_count": 16,
"execution_count": 1,
"metadata": {},
"outputs": [],
"outputs": [
{
"ename": "ModuleNotFoundError",
"evalue": "No module named 'postprocess'",
"output_type": "error",
"traceback": [
"\u001b[0;31m---------------------------------------------------------------------------\u001b[0m",
"\u001b[0;31mModuleNotFoundError\u001b[0m Traceback (most recent call last)",
"Cell \u001b[0;32mIn[1], line 4\u001b[0m\n\u001b[1;32m 2\u001b[0m \u001b[38;5;28;01mimport\u001b[39;00m \u001b[38;5;21;01mnumpy\u001b[39;00m \u001b[38;5;28;01mas\u001b[39;00m \u001b[38;5;21;01mnp\u001b[39;00m\n\u001b[1;32m 3\u001b[0m \u001b[38;5;28;01mimport\u001b[39;00m \u001b[38;5;21;01mmatplotlib\u001b[39;00m\u001b[38;5;21;01m.\u001b[39;00m\u001b[38;5;21;01mpyplot\u001b[39;00m \u001b[38;5;28;01mas\u001b[39;00m \u001b[38;5;21;01mplt\u001b[39;00m\n\u001b[0;32m----> 4\u001b[0m \u001b[38;5;28;01mimport\u001b[39;00m \u001b[38;5;21;01mpostprocess\u001b[39;00m \u001b[38;5;28;01mas\u001b[39;00m \u001b[38;5;21;01mpp\u001b[39;00m\n\u001b[1;32m 5\u001b[0m \u001b[38;5;28;01mimport\u001b[39;00m \u001b[38;5;21;01mos\u001b[39;00m\n\u001b[1;32m 6\u001b[0m \u001b[38;5;28;01mimport\u001b[39;00m \u001b[38;5;21;01mglob\u001b[39;00m\n",
"\u001b[0;31mModuleNotFoundError\u001b[0m: No module named 'postprocess'"
]
}
],
"source": [
"import sympy as sp\n",
"import numpy as np\n",
"import matplotlib.pyplot as plt\n",
"import postprocess as pp\n",
"import irrevolutions.utils.postprocess as pp\n",
"import os\n",
"import glob\n",
"\n",
Expand Down Expand Up @@ -2019,7 +2031,7 @@
],
"metadata": {
"kernelspec": {
"display_name": "fenicsx-env",
"display_name": ".venv",
"language": "python",
"name": "python3"
},
Expand All @@ -2033,7 +2045,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.12.5"
"version": "3.12.2"
},
"orig_nbformat": 4
},
Expand Down
File renamed without changes.

0 comments on commit 94d05f8

Please sign in to comment.