feat: Add new request_origin to metrics baggage
#600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new `request_origin` field informs if the policy request was a `validate` one (going through the k8s apiserver) or an `audit` one (synthetic evaluation requests generated by the audit scanner). Signed-off-by: Víctor Cuadrado Juan <[email protected]>
viccuad
changed the title
request_origin to metrics baggagerequest_origin to metrics baggage
|
merging already because it's a somewhat simple thing, and I want an image from it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to #597
This new
request_originfield informs if the policy request was avalidateone (going through the k8s apiserver) or anauditone (synthetic evaluation requests generated by the audit scanner).Test
Tested successfully with
docker compose, by adding a new grafana visualization such assum(kubewarden_policy_evaluations_total{request_origin="validate"}).Additional Information
Tradeoff
Potential improvement